• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by Ben__ · Sep 09, 2015 at 07:00 PM · c#arrayinventoryfor-loop

Array Overflow Problem

So I was making my inventory. And I want the user to be able to move items. I have a 4x6 grid of buttons all assigned in a table:

 PhysGUI = InvPanel.GetComponentsInChildren<Text> ();

That's fine, when I try to add listeners to them, all of them give me 24. The assignment is in a for loop:

     for (int i = 0; i < PhysGUI.Length; i++) {
                 Debug.Log (i.ToString ());
                 PhysGUI[i].gameObject.GetComponentInParent<Button> ().onClick.AddListener (delegate {
                     ButtonPress (i);
                 });
             }
 


ButtonPress() prints out the number that comes up immedeately, and no matter which button I push, I get 24.

Is there something I'm missing? Or what?

Comment

People who like this

0 Show 0
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

  • Sort: 
avatar image
Best Answer

Answer by anmolmahatpurkar · Sep 09, 2015 at 07:05 PM

Try this:

  for (int i = 0; i < PhysGUI.Length; i++) {
                  Debug.Log (i.ToString ());
                  int iValue = i;
 
                  PhysGUI[iValue].gameObject.GetComponentInParent<Button> ().onClick.AddListener (delegate {
                      ButtonPress (iValue);
                  });
 }

i is a local variable on the "for" block of code. Its value increments to the last number of the for loop long before you press the button. The value is PhysGUI.Length in this case, so when you press any button, it displays the last value.

Comment

People who like this

0 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta by June 9. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

How to deactivate all GameObject in a array, except last one 4 Answers

Error CS0029 Help? (Screenshot of Exact Error) 1 Answer

Can't Assign Item In Array 1 Answer

Values in Array Automatically Revert 1 Answer

Array items null but appear normal in inspector 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges