• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by Ante · Sep 23, 2015 at 08:57 PM · uieventsinteger

Passing an int to a function from an onClick event gives the same value on every button.

So I'm calling this to make a bunch of buttons with different resolutions on them and set an onClick event on them that calls the function after it.

             for (int x = resString.Length-1; x >= 0; x--)
             {
                 GameObject newButton = (GameObject)Instantiate(resolutionButton);
                 newButton.transform.SetParent(resolutionPanel);
                 newButton.transform.localPosition = Vector3.zero;
                 newButton.transform.localScale = Vector2.one;
                 newButton.name = x.ToString();
                 newButton.transform.FindChild("Text").GetComponent<Text>().text = resString[x];
                 checks[x] = newButton.transform.FindChild("Check").GetComponent<Image>();
                 checks[x].enabled = (currentRes == x);
                 int newResInt = x;
                 Debug.Log(newResInt);
                 newButton.GetComponent<Button>().onClick.AddListener(
                 () => { SetResolutionIndex(newResInt, newButton); }
                 );
             }
     public void SetResolutionIndex(int theNewIndex, GameObject thisButton)
     {
         Debug.Log("New Index:" + EventSystem.current.currentInputModule.name);
         checkSelectedIndex = theNewIndex;
         DoChecks();
     }

But I have a problem with the int. It seems that it is using the last set value of "x" on every button (so in this case, 0), even though I am creating a new local integer, newResInt, to pass into the function. I've looked into this issue already, and people have said that should fix it, however, newResInt still seems to be a pointer to x. What am I doing wrong?

Comment

People who like this

0 Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image etopsirhc · Sep 23, 2015 at 09:33 PM 1
Share

try this newResInt = x - 0;

not sure if it will work, but this way the newResInt shouldn't be linking to the x as i suspect it may be.

if it's not that, then it may have to do with the loop itself. i remember hearing that foreach loops sometimes have problems with similar stuff, so maybe it's related. but if you create a function outside of the loop that does all the work inside it (line 2-15) it should fix it, if it's that.

avatar image Ante etopsirhc · Sep 23, 2015 at 09:44 PM 0
Share

newResInt = x-0 didn't work, but that was a good idea anyway. I thought it might for a second there. HOWEVER, moving everything to a new function and calling that did end up working. Thanks for your help!

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

32 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Get Inputfield integer 2 Answers

Difference between EventType.ContextClick and EventType.MouseDown with Event.button == 1? 1 Answer

UI: Mouse events not working 1 Answer

Unity 2019.3 any way to make mouse events pass thru an UI element without disabling "Raycast Target" ? 2 Answers

Using Delegates for separating UI and Logic, are these in the right place? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges