• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
Question by derJess · Oct 13, 2015 at 12:46 PM · 2dscripting problemmovementbeginner

2D moving Script

So i try to make a simple movement script, the player is not effected by gravity ( but yes i have a ridgidbody2d attached to him) I dont want to do a Platformer, the player just should go upwards, downwards, right, left and diagonal here is my script so far

 public float horizontal;
 public float vertical;

 void Start () {
 
 }

 void Update () {

     if (Input.GetKey(KeyCode.W))
     {
         GetComponent<Rigidbody2D>().velocity = new Vector2(GetComponent<Rigidbody2D>().velocity.x, vertical);
     }

     if (Input.GetKey(KeyCode.S))
     {
         GetComponent<Rigidbody2D>().velocity = new Vector2(GetComponent<Rigidbody2D>().velocity.x, -vertical);
     }

         if (Input.GetKey(KeyCode.A))
     {
         GetComponent<Rigidbody2D>().velocity = new Vector2(-horizontal, GetComponent<Rigidbody2D>().velocity.y);
     }

     if (Input.GetKey(KeyCode.D))
     {
         GetComponent<Rigidbody2D>().velocity = new Vector2(horizontal, GetComponent<Rigidbody2D>().velocity.y);
     }

 }

}

everything is fine, until i try to move the player diagonal. It moves diagonal but i cant get back to the left, right, up and down

Comment

People who like this

0 Show 0
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
Best Answer

Answer by Dave-Carlile · Oct 13, 2015 at 12:58 PM

The issue is that you never set a velocity value back to 0 when the key is released. A simple solution is to set the Rigidbody's velocity to 0 at the beginning of Update and then change it based on the current keys. But this will have the side effect that if no keys are pressed then it won't move at all. Is that the behavior you're looking for?

Another word of advice which will make your code simpler. Add a field to the class to hold a reference to the rigid body component. Set it in Start...

 Rigidbody2D rigidBody;

 void Start()
 {
     rigidBody = GetComponent<RigidBody2D>();
 }

Now in Update you can just use the rigidbody field instead of having to call GetComponent all of the time. This will help performance (because GetComponent has a lot of work to do to find the component) and make your code very much more readable and easier to maintain.

Comment
derJess

People who like this

1 Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image derJess · Oct 13, 2015 at 02:09 PM 0
Share

thank you, the first answere was exactly what i was looking for

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Update about the future of Unity Answers

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta later in June. Please note, we are aiming to set Unity Answers to read-only mode on the 31st of May in order to prepare for the final data migration.

For more information, please read our full announcement.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

How do I move a prefab the same speed as my scrolling background? 0 Answers

I can't figure out why this variable is not updating 0 Answers

My 2d movement script isn't working 0 Answers

Is there a way I can make one script for all my buttons in my game? 1 Answer

How can I change velocity from a different script? 3 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges