• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by Zeronev · Nov 02, 2015 at 04:56 PM · c#listremove

Removing items from list by OnTriggerExit

Hi, I have certain Items inside a collider, and all the items inside the collider are taken inside a list. But when I take an item outside the collider (And destroying it). It gives me an error, about still trying accesing the item when the item is destroyed.

I believe the error is in the part of "OnTriggerExit", So you don't have to read the entire code

The error is (I think) that the item is not removed from the list.

This is my code:

public class ActivateTextMeshes : MonoBehaviour { public List textMeshes = new List();

 void OnTriggerEnter(Collider other)
 {
     if (other.GetComponentInChildren<TextMesh>() && other.gameObject.tag == "PickableItem")
     {
         /* ADDS ALL TEXT MESHES TO LIST */
         if (!textMeshes.Contains(other.gameObject.GetComponent<TextMesh>()))
         {
             textMeshes.Add(other.gameObject.GetComponentInChildren<TextMesh>());
         }
     }

     /* CHECKS IF THE PLAYER IS INSIDE THE COLLIDER */
     if (other.GetComponent<Collider>().bounds.Contains(player.transform.position))
     {
         ActivateAllTextMeshes();
     }

 }

 void OnTriggerExit(Collider other)
 {
     if (!other.GetComponentInChildren<TextMesh>() && other.gameObject.tag == "PickableItem")
     {
         textMeshes.Remove(other.gameObject.GetComponentInChildren<TextMesh>());
         textMeshes.TrimExcess();
     }

     //If the player exits from the collider
     if (other.GetComponent<Collider>().bounds.Contains(player.transform.position))
     {
         DeactivateAllTextMeshes();
     }
 }


 void ActivateAllTextMeshes()
 {
     for (int i = 0; i < textMeshes.Count; i++)
     {
         textMeshes[i].GetComponent<TextMesh>().gameObject.SetActive(true);
     }
 }

 void DeactivateAllTextMeshes()
 {
     for (int i = 0; i < textMeshes.Count; i++)
     {
         textMeshes[i].GetComponent<TextMesh>().gameObject.SetActive(false);
     }
 }

}

Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Fire_Cube · Nov 02, 2015 at 05:04 PM 0
Share

line 22 and 29, i think you inverted the '!' :)

avatar image Zeronev Fire_Cube · Nov 02, 2015 at 06:15 PM 0
Share

Checked. Actually the line 29 to 32 works fine :)

2 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Zeronev · Nov 02, 2015 at 09:03 PM

Fixed this with this Godly Loop:

 void RemoveUnnesessaryItems()
     {
         for (int i = 0; i < textMeshes.Count; i++)
         {
             if (textMeshes[i] == null)
             {
                 textMeshes.Remove(textMeshes[i]);
             }
         }
     }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
1

Answer by Fire_Cube · Nov 02, 2015 at 07:27 PM

Line 22, I think there shouldn't be the '!', but line 29 i think there should be one. Not sure but can be just this.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

30 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Add object of specific width to a List 1 Answer

Why is my listdisplaying that an item was removed? 0 Answers

Get all Children of an Object with a certain component 0 Answers

Most efficient way to store information in an inspector dropdown menu? 0 Answers

Play animation from List of objects by its [i] - Please need fast help :( 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges