Question by KryChaos · Nov 25, 2015 at 08:57 PM · scripting problem scripting beginner

Difficulty Moving Sprite left and right when walking left and right.

I want the sprite to look left and right when walking but the script wont work.

using UnityEngine; using System.Collections;

public class player : MonoBehaviour {

 public float maxSpeed = 3;
 public float speed = 50f;
 public float jumpPower = 150f;
 
 public bool grounded;
 
 private Rigidbody2D rb2d;
 private Animator anim;
 
 void Start () 
 {
     rb2d = gameObject.GetComponent<Rigidbody2D> ();
     anim = gameObject.GetComponent<Animator> ();

     if (Input.GetAxis ("Horizontal") < -0.1f) {
         transform.localScale = new Vector3 (-1, 1, 1);
     }

     if (Input.GetAxis ("Horizontal") > 0.1f) {
         transform.localScale = new Vector3(1, 1, 1);
     }

         

 }
 
 
 void Update () 
 {
     
     anim.SetBool ("Grounded", grounded);
     anim.SetFloat("Speed", Mathf.Abs(Input.GetAxis("Horizontal")));
     
 }
 
 void FixedUpdate()
 {
     float h = Input.GetAxis("Horizontal");
     
     
     rb2d.AddForce((Vector2.right * speed) * h);
     
     if (rb2d.velocity.x > maxSpeed) {
         rb2d.velocity = new Vector2 (maxSpeed, rb2d.velocity.y);
     }
     
     if (rb2d.velocity.x < -maxSpeed) {
         rb2d.velocity = new Vector2 (-maxSpeed, rb2d.velocity.y);
     }
     
     
 }

}

Add comment · Show 4

timdouglas90 · Nov 25, 2015 at 11:43 PM 1

What's not working about it? Need a bit more info since the code looks a bit weird...I'd have done something like this...

 using UnityEngine; 
 using System.Collections;
 
 public class player : $$anonymous$$onoBehaviour {
 
  public float maxSpeed = 3;
  public float speed = 50f;
  public float jumpPower = 150f;
  
  public bool grounded;
  
  private Rigidbody2D rb2d;
  private Animator anim;
  
  void Start () 
  {
      rb2d = gameObject.GetComponent<Rigidbody2D> ();
      anim = gameObject.GetComponent<Animator> ();
      if (Input.GetAxis ("Horizontal") < -0.1f) {
          transform.localScale = new Vector3 (-1, 1, 1);
      }
      if (Input.GetAxis ("Horizontal") > 0.1f) {
          transform.localScale = new Vector3(1, 1, 1); 
          //Not sure why you set a vector 3 
          //since you only need a vector 2 for 2D...
          //Also not sure why you set them to 1?
      }
          
  }
  
  
  void Update () 
  {
      
      anim.SetBool ("Grounded", grounded);
      anim.SetFloat("Speed", $$anonymous$$athf.Abs(Input.GetAxis("Horizontal")));
      
  }
  
  void FixedUpdate()
  {
      float h = Input.GetAxis("Horizontal");
      
      if(Input.GetAxis("Horizontal") < 0)
      {
         rb2d.AddForce(Vector2.left * speed);
      }
 
      if(Input.GetAxis("Horizontal") > 0)
      {
         rb2d.AddForce(Vector2.right * speed);
      }
 
      if(Input.GetAxis("Horizontal") == 0)
      {
         rb2d.velocity = 0;
      }
  }
  
 }

KryChaos · Nov 27, 2015 at 11:09 AM 0

When i walk left, i want the sprite to look left, and right when walking right.

timdouglas90 KryChaos · Nov 27, 2015 at 07:33 PM 0

Ah in that case then you'll need a simple bool for isFacingRight and then set the local transform scale to positive and negative values on the x axis like so...

 using UnityEngine;
 using System.Collections;
 
     public class Player : $$anonymous$$onoBehaviour
     {
         private Rigidbody2D rb2d;
         private bool isFacingRight;
 
         void Start()
         {
             rb2d = GetComponent<Rigidbody2D>();
         }
 
         void FixedUpdate() 
         {
             float h = Input.GetAxis("Horizontal");
               
               //move LEFT
              if(Input.GetAxis("Horizontal") < 0)
               {
                  rb2d.AddForce(Vector2.left * speed * Time.Deltatime);
                  if(isFacingRight)
                  {
                      Flip();
                  }
               }
              
              //move RIGHT
               if(Input.GetAxis("Horizontal") > 0)
               {
                  rb2d.AddForce(Vector2.right * speed * Time.Deltatime);
                  if(!isFacingRight)
                  {
                      Flip();
                  }
               }
  
              //STOP moving
             if(Input.GetAxis("Horizontal") == 0)
               {
                  rb2d.velocity = 0;
               }
         }
 
         void Flip()
         {
             transform.localScale = new Vector3(-transform.localScale.x, transform.localScale.y, transform.localScale.z);
             _isFacingRight = transform.localScale.x > 0;
         }
     }

NOTE: This is untested code so use with care, I lifted Flip() straight from my own character controller :)

LazyElephant · Nov 28, 2015 at 02:58 AM 0

It looks like the main problem is that all your code to handle the sprite facing is in your Start () function, which only runs once. Try moving it to your update or fixed update.