Question by stu_chineseroom · Jan 13, 2016 at 09:35 AM · unity 5 serialization lightmapping saving meshrenderer

Saving changes to MeshRenderer at edit time

Hi,

I'm changing a few properties of the MeshRenderer component on my objects at edit time (e.g. lightmapIndex, lightmapScaleOffset). I also update the LightmapSettings structure since I'm setting up some custom lightmaps. T$$anonymous$$s all seems to work fine, however when I quit and reload the level the changes are gone. If I were making edits to the meshes themselves I'd look at editing the sharedMesh or creating a new asset, but since t$$anonymous$$s is the MeshRenderer components and a general engine structure, I'm not sure how to best proceed.

For what it's worth, I've tried using EditorUtility.SetDirty(), PrefabUtility.RecordPrefabInstancePropertyModifications() etc to make sure I'm notifying the editor of my changes. I can view the intended values in the Lighting/Object tab under Baked Lightmap too.

Any help would be much appreciated. Thanks, Stu

2 Show 7

Fattie · Jan 13, 2016 at 01:01 PM 0

good question

Baste · Jan 13, 2016 at 01:05 PM 0

How are you editing the changes? If you're using SerializedProperties, you need to use their version of SetDirty (ApplyModifiedProperties).

If not, make sure that you're calling SetDirty on the MeshRenderer component itself.

stu_chineseroom · Jan 13, 2016 at 06:51 PM 0

Hi @Baste, thanks for replying.

I'm currently doing this essentially:

 GameObject go = GameObject.Find(meshName);
 Renderer mr = go.GetComponent<Renderer>();
 
 // Update the values on the MeshRenderer
 mr.gameObject.isStatic = true;
 mr.lightmapScaleOffset = scaleOffset;
 mr.lightmapIndex = lightmapIndex;
 
 // Throw any dirty flags into the mix that I can find
 PrefabUtility.RecordPrefabInstancePropertyModifications(go);
 EditorUtility.SetDirty(go);
 EditorUtility.SetDirty(mr);

As per the code, I've tried setting the dirty flag on the GameObject and the MeshRenderer component and have tried many combinations thereof. I don't think I can set a dirty flag on the LightmapSettings structure itself, so I'm not sure what I can do to coax that to save either.

Thanks for the help, Stu

stu_chineseroom · Jan 18, 2016 at 02:49 PM 0

I've additionally tried cloning the objects, setting the new params on the clones and then destroying the originals. Sadly this doesn't work either. I thought perhaps the values might get pulled from the prefab so I use PrefabUtility.DisconnectPrefabInstance() after cloning but to no avail.

I've also tried updating the components on the prefabs themselves, but that didn't seem to make any difference (I changed the hideFlags to allow editing first, just in case).

I'm kinda out of ideas now other than setting the values during Awake() at runtime to make sure they persist during gameplay at least. Any other thoughts?

cheers, stu

Baste stu_chineseroom · Jan 19, 2016 at 12:06 AM 0

Okay, I've been noticing similar things too, and just replied to a thread on the forums.

At one point, the SetDirty method stopped setting the scene dirty. I'm not sure if it's a bug or a horribly bad idea, but in the mean time, you'll have to manually set the scene dirty when you do a change.

This seems to be done through the very wordy:

 EditorSceneManager.MarkSceneDirty(EditorSceneManager.GetActiveScene());

Try that.

stu_chineseroom Baste · Jan 19, 2016 at 11:47 AM 0

Hi Baste,

Thanks for the suggestion! I upgraded to Unity 5.3 to get access to EditorSceneManager but sadly it still doesn't seem to save the MeshRenderer changes I need. I also tried using Undo.RecordObject from the forum thread as I'd not considered that before but it still doesn't make the changes stick. Perhaps the settings are saved, but the engine is overwriting them with the defaults on-play or reload (e.g. offsetScale is reset to <0, 0, 1, 1>, lightmapIndex to -1).

I'm now beginning to wonder if I'm doing something fundamentally not possible by injecting these lighting values. If I clone an object, create a new sharedMesh copying over the data, create an actual asset from that and then instantiate that into the scene, the MeshRenderer lightmap values still get reset. :/ Maybe it's time for a new approach...

Thanks again for the suggestion, much appreciated!

Show more comments

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Saving changes to MeshRenderer at edit time

0 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions