• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by NohanG · Jan 18, 2016 at 09:25 PM · c#coroutineienumeratorfreezing

Coroutine crashes game

I have a coroutine set up to rotate a security camera. When I first load up the game everything is fine ,but when the camera comes into view the game freezes. Here's the script: using UnityEngine; using System.Collections;

 public class StealthCameras : MonoBehaviour
 {
     public Transform target;
     public Transform right;
     public Transform left;
 
     void OnTriggerEnter()
     {
         Player.player.debugLogsText = "You lost a life! Don't enter the camera's view!";
         //Player.player.LostLife();
     }
     void Start()
     {
         StartCoroutine(CameraRotation(target, right, left, 0.1f));
     }
     IEnumerator CameraRotation(Transform target, Transform left, Transform right, float speed)
     {
         target.rotation = left.rotation;
 
         while (true)
         {
             if(target.rotation == left.rotation)
             {
                 yield return new WaitForSeconds(5);
                 target.rotation = Quaternion.Lerp(left.rotation, right.rotation, Time.time * speed);
             }
             else if(target.rotation == right.rotation)
             {
                 yield return new WaitForSeconds(5);
                 target.rotation = Quaternion.Lerp(right.rotation, left.rotation, Time.time * speed);
             }
         }
     }
 }

Thanks for any help in advance.

Comment

People who like this

0 Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image SkandYxyz · Jan 18, 2016 at 09:41 PM 0
Share

I am not 100% sure, but it would be more save to use <= or >= instead of == Second thing I see is that you probably end up in an enless loop if target.rotation is not left.rotation and not right.rotation. this might cause the freeze. just a guess.

best, Andre

2 Replies

  • Sort: 
avatar image
Best Answer

Answer by corewise · Jan 18, 2016 at 10:00 PM

You get stuck in an infinite loop as soon as target.rotation != left.rotation and target.rotation != right.rotation. I would do something like this (assuming you want to stop for 5 seconds each time it is about to switch direction):

     IEnumerator CameraRotation(Transform target, Transform left, Transform right, float speed)
     {
         bool wasTurningRight = false;
         bool turnRight = true;
         target.rotation = left.rotation;
 
         while (true)
         {
             yield return new WaitForSeconds(0.05f);
 
             if (target.rotation == left.rotation && !turnRight)
             {
                 turnRight = true;
             }
             else if (target.rotation == right.rotation && turnRight)
             {
                 turnRight = false;
             }
 
             if (turnRight)
             {
                 if (!wasTurningRight)
                 {
                     wasTurningRight = true;
                     yield return new WaitForSeconds(5);
                 }
                 target.rotation = Quaternion.Lerp(left.rotation, right.rotation, Time.time * speed);
             } else {
                 if (wasTurningRight)
                 {
                     wasTurningRight = false;
                     yield return new WaitForSeconds(5);
                 }
                 target.rotation = Quaternion.Lerp(right.rotation, left.rotation, Time.time * speed);
             }
         }
     }
Comment
NohanG

People who like this

1 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image

Answer by Jessespike · Jan 18, 2016 at 09:57 PM

What happens if target.rotation is not equals to left or right? Try adding an else statement to handle that:

  else
  {
       yield return new WaitForSeconds(1);                  
  }
Comment

People who like this

0 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta by June 9. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.

Follow this Question

Answers Answers and Comments

5 People are following this question.

avatar image avatar image avatar image avatar image avatar image

Related Questions

Why Won't My Coroutine Yield? 2 Answers

Make a laser flickering. 1 Answer

IEumerator not recognising when a bool has switched 1 Answer

Multiple Cars not working 1 Answer

Returning an IEnumerator as an int? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges