How do I code this in a simpler way?

Question

Hello,

So the below code works fine but I can't help thinking there must be a more efficient way of doing this. The frequency of the colour change doesn't matter atm, I just want to be able to sync it somehow with the collisions.

Many Thanks

J

using UnityEngine; using System.Collections;

 public class DestroyedByBall : MonoBehaviour 
 {
     //int count; .
     public int countStart; //everytime another collider hits this start value reduces by 1/ 
 
     void Start()
     {
         countStart =30; 
     } 
 
     void OnTriggerEnter (Collider other)
     {
 
         if (other.CompareTag ("Player")) {
             countStart-- ; //everytime another collider hits this goes up one
 
         } 
 
     if (countStart == 20) 
         {
             gameObject.transform.parent.GetComponent<Renderer> ().material.color = Color.black; 
              
         }
 
         if (countStart == 10) 
         {
             gameObject.transform.parent.GetComponent<Renderer> ().material.color = Color.yellow; 
 
         }
 
         if (countStart == 5) 
         {
             gameObject.transform.parent.GetComponent<Renderer> ().material.color = Color.red; 
 
         }
 
         if (countStart == 0) 
         {
              
             //destroys parent of gameoject ie the whole gameobject
             Destroy (transform.parent.gameObject); 
         }
     }
 
 
 
 }

Answer 1

EDIT: Looks like someone beat me to it!

You could do something like this:

 using UnityEngine;
 
 public class DestroyedByBall : MonoBehaviour
 {
     public int countStart = 30;
     Material material;
 
     void Start()
     {
         material = transform.parent.GetComponent<Renderer>().material;
     }
 
     void OnTriggerEnter(Collider other)
     {
         if (other.CompareTag("Player"))
         {
             countStart--;
             HandleCountdown();
         }
     }
 
     void HandleCountdown()
     {
         switch (countStart)
         {
             case 20:
                 ChangeMaterialColor(Color.black);
                 break;
             case 10:
                 ChangeMaterialColor(Color.yellow);
                 break;
             case 5:
                 ChangeMaterialColor(Color.red);
                 break;
             case 0:
                 Destroy(transform.parent.gameObject);
                 break;
             default:
                 break;
         }
     }
 
     void ChangeMaterialColor(Color matColor)
     {
         material.color = matColor;
     }
 }

Answer 2

Answer by Johane · Feb 14, 2016 at 10:05 PM

Thanks to both @EmHuynh and @Ahndrakhul! Really helpful advise, much obliged!

J

Add comment · Show 1 · Share

EmHuynh · Feb 15, 2016 at 01:36 AM 0

Share

Glad we could help!

How do I code this in a simpler way?

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions