Question by security18 · Mar 16, 2016 at 12:38 PM · c#editor editor-scripting propertydrawer property

PropertyDrawer let's dissapear my INT

Hello,

I've made a propertydrawer that shows my int as a drop down box, t$$anonymous$$s works fine. Only the problem is sometimes (after being in playmode) the dropdown disappears. T$$anonymous$$s is used to show the drop down:

 [MyProperty..]
 public int StartMenu;

And to get the dropdown i use:

 [CustomPropertyDrawer(typeof(MyProp))]
 public class MyClassDrawer : PropertyDrawer
 {
     private string[] menus;
 
     public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
     {
         RegisterMenus();
 
         if (property == null)
             return;
 
         if (property.propertyType == SerializedPropertyType.Integer)
         {
             int current = property.intValue;
 
             if (position == null || menus == null)
                 return;
 
             if (menus == null)
                 return;
 
             current = EditorGUI.Popup(position, "Menu to open", current, menus);
 
             property.intValue = current;
         }
     }
 
     private void RegisterMenus()
     {
         if (MenuManager.instance == null)
             return;
 
         List<Menus> tempList = new List<Menus>();
 
 
         foreach (Menus menu in MenuManager.instance.menus)
         {
             if (menu != null)
             {
                 if (menu.menu != null)
                 {
                     if (!tempList.Contains(menu))
                         tempList.Add(menu);
                 }
             }
         }
 
         menus = new string[tempList.Count];
 
 
         for (int i = 0; i < tempList.Count; i++)
         {
             menus[i] = tempList[i].menuName;
         }
     }
 }

In the Menumanager.instance i have a list with classes that contains their names and gameobjects. (They are public so you can set them by hand).

Thanks in advance!!

0 Show 3

Baste · Mar 16, 2016 at 02:16 PM 0

When you go to and from play mode, all objects are deleted and recreated. Sometimes, the selected object is not updated properly, meaning that the selected object will be the deleted one from play mode.

If that's what's happening, it's this line that's kicking in:

 if (property == null)
     return;

And the dropdown will reappear if you deselect the object and select it again. Is that the case?

Bunny83 · Mar 16, 2016 at 03:20 PM 0

I guess that the Menumanager.instance has become null. If it's a single static field, then this will be the case as when entering / leaving playmode static fields are usually erased.

The problem most likely is not in your propertydrawer. A propertydrawer is never called with any of it's parameters being null. Also "position" is a Rect and therefore a value type. It can't be null. The null check most likely will create garbage as the rect has to be boxed.

Also your "menus" null check is redundant (line 17 and 20).

It's good that you have many consistency checks. However this is editor code which should work 100% the time unless something is wrong. If something is wrong you should at least use Debug.LogWarning / LogError to inform the user what's wrong.

So your check inside RegisterMenus could look like this:

 if (MenuManager.instance == null)
 {
     Debug.LogWarning("MenuManager.instance == null");
     return;
 }

This log, if it's hit will also contain a stacktrace so you or the user can see where the problem was raised.

security18 Bunny83 · Mar 16, 2016 at 09:24 PM 0

Thanks for the response!

Indeed the menumanager is null, i've added a log warning now. I've removed the == null for the property only now is my question how to prevent it from being null?

Thansk in advance!

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

PropertyDrawer let's dissapear my INT

0 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions