• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
Question by Brutalitywarlord · May 06, 2016 at 03:51 PM · c#uibutton2d gameonclick

Detecting a button click

I'm trying to spawn a unit in a 2D turn based war game, but the unfortunate reality is the On-click command doesn't work, it's included in the code below but it is completely dis-functional

does anyone know why i can;t use the On-click method here?

Code is included below with comments to $$anonymous$$ghlight problem code

 using UnityEngine;
 using System.Collections;
 using UnityEngine.UI;
 
 
 public class PlayerBehavior : MonoBehaviour {
     
     //public bool PlayersTurn;
     //public int ActionsPerTurn;
     public BoardManager boardManager;
     
     private Vector2 SelectedPosition;
     private GameObject Mbutton;
     private GameObject Bbutton;
     private GameObject Abutton;
     //private bool enemysTurn;
     
     void Start () {
         boardManager = GetComponent<BoardManager> ();
         Mbutton = GameObject.FindGameObjectWithTag("SpawnMsoldier");
         Abutton = GameObject.FindGameObjectWithTag("SpawnAsoldier");
         Bbutton = GameObject.FindGameObjectWithTag("SpawnBSoldier");
         Mbutton.gameObject.SetActive(false);
         Bbutton.gameObject.SetActive(false);
         Abutton.gameObject.SetActive(false);
     }
     // Update is called once per frame
     void Update () {
         
         if (Input.GetMouseButtonDown(0))
         {
             ClickSelect();
             Debug.Log(ClickSelect());
             if (ClickSelect() == GameObject.FindGameObjectWithTag("PlayerHQ"))
             {
                 Mbutton.gameObject.SetActive(true);
                 Bbutton.gameObject.SetActive(true);
                 Abutton.gameObject.SetActive(true);
                                 //T$$anonymous$$s is the problem code, for some reason, onClick is not useable
                 if (Mbutton.onClick == true)
                 {
                     Debug.Log("Testing..");
                     Instantiate (boardManager.PlayerUnits[3],new Vector3 (1,1,0f),Quaternion.identity);        
                 }
                 
             }
             
             if (ClickSelect() != GameObject.FindGameObjectWithTag("PlayerHQ"))
             {
                 Mbutton.gameObject.SetActive(false);
                 Bbutton.gameObject.SetActive(false);
                 Abutton.gameObject.SetActive(false);
             }
             
         }
         
     }
     GameObject ClickSelect()
     {
         RaycastHit2D $$anonymous$$t = Physics2D.Raycast(Camera.main.ScreenToWorldPoint(Input.mousePosition), Vector2.zero);
         
         if ($$anonymous$$t)
         {
             Debug.Log($$anonymous$$t.transform.name);
             return $$anonymous$$t.transform.gameObject;
         }
         else return null;
     }
 }

Comment

People who like this

0 Show 0
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image

Answer by M-Hanssen · May 09, 2016 at 03:08 PM

 private GameObject Mbutton;

Should be:

 private Button Mbutton;

And initialize them with:

 Mbutton = FindGameObjectWithTag("SpawnMsoldier").GetComponent<Button>();

Notice that "FindGameObjectWithTag" in general is bad practice. Use the inspector to fill the button as public variable or make sure the button has a unique script on it, so you can find it by type.

Comment

People who like this

0 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

How do I make a UI Buttion play an Animation when pressed? 0 Answers

AddListener not working after build 0 Answers

C# - Creating Canvas UI button on click in code 2 Answers

How to find the position of a button onClick? (array) 0 Answers

My prototype uses OnClick to fire projectiles, but so does my button 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges