• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by lgorse · May 09, 2016 at 03:31 PM · scripting problemterrainvrfloatheightmap

Incremental terrain height increase limited by float size

I'm setting up a sandbox game for users where they can raise and lower terrain by clicking on the Cardboard trigger (it's a VR app).

Here's a video of how the interface works (includes console tracking): https://www.youtube.com/watch?v=UGgsdZSSBjQ&feature=youtu.be

The issue is that the user clicks a couple of times and then the heightening stops.

This, I think is due to the fact that the height reaches 0.99f (so cannot go over 1f). You can see that if you watch the console part of the video link.

Here is my code:

public class terrainEdit : MonoBehaviour { private TerrainData tData; private Terrain terrain;

 private int xRes;
 private int yRes;

 // Use this for initialization
 void Start () {
     terrain = gameObject.GetComponent <Terrain> ();
     tData = terrain.terrainData;
     xRes = tData.heightmapWidth;
     yRes = tData.heightmapHeight;

     Cardboard.SDK.OnTrigger += editTerrain;
 
 }
 
 // Update is called once per frame
 void Update () {
 
 }

 void editTerrain(){
     float currentHeight = tData.GetHeight (5, 5);
     Debug.Log (currentHeight + "before change");
     float adjustedHeight = Mathf.Clamp(currentHeight, -1.0f, 1.0f);
     Debug.Log (adjustedHeight + " after clamp and before change");
     currentHeight = currentHeight/100 + 0.01f;
     Debug.Log (currentHeight);
     float[,] heights = new float[1,1] {{currentHeight} };


     tData.SetHeights(5,5, heights);
     
 }

 private void OnDestroy(){
     this.terrain.terrainData.SetHeights (5, 5, new[,]{ { 0.0f} });
 }

}

Note that for this experiment I'm focusing on changing the height of a single point at heightmap[5,5] - which explains those hard-coded values.

I don't understand why the values are jumping - I checked against other code samples that are trying to do terrain editing at runtime and they are using the same strategy.

This must be something to do with how I manage floats - but I'm not sure what it is.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by roland_k · May 10, 2016 at 07:05 AM

In line 25 you are dividing a float by an int which probably returns 0.0f. Try using: currentHeight = currentHeight/100f + 0.01f;

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

77 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

When I toggle off the GvrViewer the Y mouse sensivity camera look is locked 0 Answers

Beginner in C# - Simple Rotation Script 1 Answer

Load heightmap automatically 0 Answers

Terrain get sample height gives slightly wrong results,Terrain sampleheight gives SLIGHTLY wrong answer 1 Answer

Switch between 5 cameras in the game by clicking. 0 Answers

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges