• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
Question by Prezzo · May 25, 2016 at 03:08 PM · buildbuttonmenuonclicklistener

Add listener to multiple buttons

I have a menuController that creates a matrix of buttons which represent the levels. When a certain button is clicked, that level should be loaded. However, it doesn't matter which button I click, I always get level 25 returned... altough the highest possible level is only 20. I think this has something to do with the lambda expression that is set to every button over and over but I don't know how to fix this.

 public class MenuController : MonoBehaviour {
     
         public GameObject btnLevelPrefab;
         public GameObject levelContainer;
         public GameObject communicationManager;
     
         private GameObject[,] btnLevels;
     
         void Start () {
             btnLevels = new GameObject[4, 5];
     
             for(int i = 0; i < 5; i++)
             {
                 for(int j = 0; j < 4; j++)
                 {
                     btnLevels[j,i] = Instantiate(btnLevelPrefab, new Vector3(63 + j*90, 500 - i*90, 0), Quaternion.identity) as GameObject;
                     btnLevels[j,i].transform.SetParent(levelContainer.transform);
                     btnLevels[j,i].GetComponentInChildren<Text>().text = (j+1+i*4).ToString();
                     btnLevels[j,i].GetComponent<Button>().onClick.AddListener(() => { startLevel(j + 1 + i * 4); });
                 }
             }
         }
         
         private void startLevel(int level)
         {
             Debug.Log(level); // Returns 25 everytime???
             communicationManager.GetComponent<CommunicationManager>().setLevel(level);
             Application.LoadLevel(1);
         }
     }
 
 
 

Comment
Thajocoth

People who like this

1 Show 0
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

  • Sort: 
avatar image

Answer by Prezzo · May 25, 2016 at 04:19 PM

SOLUTION!!

For some reason the AddListener can only be attached to every single button when I send the button as parameter instead of an integer that represents the level.

The new working code is now:

 for(int i = 0; i < 5; i++)
         {
             for(int j = 0; j < 4; j++)
             {
                 btnLevels[j,i] = Instantiate(btnLevelPrefab, new Vector3(63 + j*90, 500 - i*90, 0), Quaternion.identity) as GameObject;
                 btnLevels[j,i].transform.SetParent(levelContainer.transform);
                 btnLevels[j,i].GetComponentInChildren<Text>().text = (j+1+i*4).ToString();
                 Button btnTemp = btnLevels[j, i].GetComponent<Button>();
                 btnLevels[j, i].GetComponent<Button>().onClick.AddListener(() => { startLevel(btnTemp); });
 
             }
         }
     }
     
     private void startLevel(Button btnLevel)
     {
         Debug.Log(btnLevel.GetComponentInChildren<Text>().text);
         communicationManager.GetComponent<CommunicationManager>().setLevel(int.Parse(btnLevel.GetComponentInChildren<Text>().text));
         Application.LoadLevel(1);
     }
Comment
Thajocoth
FurySven

People who like this

2 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image

Answer by Thajocoth · May 25, 2016 at 05:14 PM

The issue was that adding the functionality that way doesn't preserve the state of the variables used inside it.

 int i = 5;
 AddListener(() => { function(i); });
 i++;

This will call function(6) when clicked, because i later became 6. The fact that i was 5 when the listener was set up is irrelevant.

I've been burned by this before as well. I wish there was a way to say "The current value of" instead of "Whatever the value will be of" when doing that.

 (j + 1 + i * 4)

may as well be

 (4 + 1 + 5 * 4)

Which is 25.

Comment
Prezzo

People who like this

1 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta on June 13. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Add listenner to button in loop error 0 Answers

How to use Button.OnClick.AddListener? 2 Answers

Setting button.onClick.AddListener saids: InvalidCastException: Cannot cast from source type to destination type. 1 Answer

check if-statement/bool when button is pressed? 1 Answer

I AM PRAYING TO THE GODS! 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges