My FinalScore Counter adds up to infinity, why?

Question

Why is the variable WinnerScore going crazy? It keeps adding up to infinity. Could sb help me? Here is the code:

void OnGUI() { GUI.skin = skin; GUI.Label(new Rect(40, 200, 2, 2), "Collected Coins: " + tokenCount + "/" + TotalTokenCount.ToString(), skin.GetStyle("Coin")); GUI.Label(timerRect, currentTime, skin.GetStyle("Timer")); if (startTime < 5f) { skin.GetStyle("Timer").normal.textColor = WarningColor; } else { skin.GetStyle("Timer").normal.textColor = CustomColor; }

     if (ShowWinBox)
     {
         Rect WinScreenRect = new Rect(Screen.width / 2 - (winScreenWidth / 2), Screen.height / 2 - (winScreenHeight / 2), winScreenWidth, winScreenHeight);
         GUI.Box(WinScreenRect, "Click continue or press space to load the next level");
         float tokens = (float)tokenCount;
         int currentScore = (int)tokens * (int)startTime;

         **WinnerScore = WinnerScore + currentScore;**


         GUI.Label(new Rect(Screen.width / 2 - (winScreenWidth / 2) + 10, (Screen.height / 2) - 80, 100, 25), "you've finished with " + startTime + " seconds left", skin.GetStyle("Box"));
         if (tokens==1)
         {
             GUI.Label(new Rect(Screen.width / 2 - (winScreenWidth / 2) + 10, (Screen.height / 2) - 55, 50, 25), "you've collected " + tokens + " coin", skin.GetStyle("Box"));

         }
         else
         {
             GUI.Label(new Rect(Screen.width / 2 - (winScreenWidth / 2) + 10, (Screen.height / 2) - 55, 50, 25), "you've collected " + tokens + " coins", skin.GetStyle("Box"));

         }
         GUI.Label(new Rect(Screen.width / 2 - (winScreenWidth / 2) + 10, (Screen.height / 2) - 30, 100, 25), "your score is: " + currentScore, skin.GetStyle("Box"));

         if (SceneManager.GetActiveScene().buildIndex == 8)
         {
             GUI.Label(new Rect(Screen.width / 2 - (winScreenWidth / 2) + 10, ((Screen.height / 2) - 5), 100, 15), "your final score is: " + WinnerScore, skin.GetStyle("Box"));
         }

}

Answer 1

Best Answer

Answer by ScaniX · Jul 16, 2016 at 07:33 PM

The OnGUI() method is called repeatedly like the Update(), so you have to make sure to only execute the code that changes the score once.

At least in the posted code I cannot see anything that sets tokenCount or startTime to zero, so it will add those values to your score on every gui draw.

Add comment · Share

Answer 2

Answer by MegaWave_ · Jul 16, 2016 at 07:14 PM

I can't really see what is wrong here but maybe

WinnerScore = WinnerScore + currentScore;

is called more times than it should and it goes like:

 currentScore = 1
 +
 WinnerScore = 1
 =
 WinnerScore = 2

then it goes

 currentScore = 1
 +
 WinnerScore = 2
 =
 WinnerScore = 3

and so on.

Add comment · Show 4 · Share

czajenczini · Jul 16, 2016 at 07:22 PM 0

Share

How should I add it then? (currentScore variable works fine) Btw thank you so much for the response

MegaWave_ czajenczini · Jul 16, 2016 at 07:28 PM 1

Share

I don't know but you should make something like if (scoreCounted = false) { WinnerScore = WinnerScore + currentScore; scoreCounted = true; } This might be a bad way to do it since I am not the best, but I hope it works :)

czajenczini MegaWave_ · Jul 17, 2016 at 09:45 AM 0

Share

It worked, I've also changed WinnerScore to static :)

czajenczini · Jul 16, 2016 at 07:29 PM 0

Share

I'll try it, thank you :)

Answer 3

Answer by wojtask12 · Jul 16, 2016 at 07:35 PM

Why don't you use NGUI instead of the old one? I guess you've got this code inside of OnGUI function which can be called multiple times in a second (read here https://docs.unity3d.com/ScriptReference/MonoBehaviour.OnGUI.html), so it adds the currentScore on each call - which leads to infinity

Add comment · Share

My FinalScore Counter adds up to infinity, why?

3 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions