• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Joyble · Aug 25, 2016 at 04:44 PM · charactercontrollerjumping

Animation plays but character isn't jumping

I'm trying to use character controller to jump. Jump animation plays like it should but the character doesn't go up at all.

Here's the script, so if someone can tell me what's wrong with the script and how to fix it, please do.

 using UnityEngine;
 using System.Collections;
 using System;
 
 public class DummyCharJump : MonoBehaviour {
 
     public bool onGround;
     public float minJump;
     public float delayTime = 0.5f;
     private bool allowJump = true;
     public float jumpSpeed = 10F;
     public float gravity = 20.0F;
     public Rigidbody rbody;
     
     private Vector3 moveDirection = Vector3.zero;
 
     
     // Use this for initialization
     void Start ()
     {
         onGround = true;
         minJump = Stats.DummyJMP;
         rbody = GetComponent<Rigidbody>();
 
     }
 
     // Update is called once per frame
     void Update()
     {
 
 
 
         if (onGround && Input.GetButtonDown("Jump"))
         {
             //Call Delay
             StartCoroutine(JumpDelay());
         }
 
         //holding jump button//
 
 
 
         if (allowJump && onGround)
         { 
             
             CharacterController controller = GetComponent<CharacterController>();
 
             if (controller.isGrounded) {
                 moveDirection = new Vector3();
                 moveDirection = transform.TransformDirection(moveDirection);
                 if (Input.GetButton ("Jump"))
                     moveDirection.y = jumpSpeed * minJump;
         }
                 
           
             
         }
     }
 
     //Delay then enable Jump
     private IEnumerator JumpDelay()
     {
        
         yield return new WaitForSeconds(delayTime);
         allowJump = true;
     }
 
 
 
     void OnCollisionEnter(Collision other)
     {
         if(other.gameObject.CompareTag("ground"))
         {
             onGround = true;
         }
     }
 
 
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by lambmeow · Aug 26, 2016 at 04:47 AM

You have to change Input.GetButtonDown() to Input.GetButton() since GetButton() will return true while the button is pressed down no matter what while GetButtonDown() is only true for the frame that is pressed and will reset to false in the next frame

Also, you have another Input.getButton on your if(AllowAll && onGround ) that is completely unnecessary since :

 if (onGround && Input.GetButtonDown("Jump"))

already covers the button input.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

62 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Using isGrounded with a RigidBody 2 Answers

Need help with CharacterController script 4 Answers

How to make character controller forward jump a certain distance? 1 Answer

wall glitch while jumping using a character controller 2 Answers

Character Controller problem when jumping 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges