• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by Olamire · Sep 10, 2016 at 06:22 PM · instantiatecrashinglooping

For and While loop crashing unity and system

i'm trying to write the code for the pistol to generate a bullet every 2 seconds once its instantiated so i used this code

public class Pistol : MonoBehaviour { int BulletCounter; public GameObject bullet; public GameObject WhereToSpawn; int i; // Use this for initialization void Start () {

     while (gameObject.activeSelf == true)
     {
         bullet = (GameObject)Instantiate(bullet, WhereToSpawn.transform.position, Quaternion.identity);
         new WaitForSeconds  (2);
     }
   
 }

problem is this crashes my entire system when i try to play it. what should i do?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by ScaniX · Sep 10, 2016 at 06:29 PM

Your code consists of an endless loop. Unity is waiting for it to finish... forever...

You need to understand how those callback methods of MonoBehaviours work. They are callbacks that get invoked when an event occurred, an object is initialized or in a repeated pattern (per frame or in a certain interval).

You should never add code to those methods that is taking long (or even forever) to finish. If you need something like this, you can create a coroutine. In your case I think you will be better off without one.

 public class Pistol : MonoBehaviour { 
     int BulletCounter; 
     public GameObject bullet; 
     public GameObject WhereToSpawn; 
     int i; 
     float lastSpawnTime;

     // Use this for initialization 
     void Start () {
         lastSpawnTime = Time.time;
     }

     void Update() {
          if (Time.time - lastSpawnTime > 2) {
              bullet = (GameObject)Instantiate(bullet, WhereToSpawn.transform.position, Quaternion.identity);
              lastSpawnTime = Time.time;
         }
     }
  }




Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Olamire · Sep 25, 2016 at 10:22 AM 0
Share

this solved my problem, thanks!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Trying to make a void run continously at a interval (changeable by variable) while finger is held on screen 0 Answers

How to destroy a gameobject before instantiating another one in its location? 1 Answer

trying to instantiate an object a random number of times ,how do i spawn something in a random ammount of times? 0 Answers

Spawn system that doesn't instantiated enemies on top of player or each other (C#) 2 Answers

Coroutine Not Starting - Crashes Instead? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges