"not all code paths return a value"

Question

hi!

Beginner here. I need this method to return a GameObject based on it's id (which is an enum named "ItemID"), and I don't know where I'm missing a return value. "pickUpDict" is the dictionary from which to retrieve the GameObject, which is located in the same script and populated on Awake.

Hope someone can help me out. Thanx in advance!

   public static Dictionary <GameObject, ItemID> pickUpDict = new Dictionary <GameObject, ItemID>(); //container for all pickups

 //return gameobject based on item id, from dictionary
 public static GameObject ReturnPrefab (ItemID id) {
             GameObject go = null;
             foreach (var kvp in pickUpDict) {
                 if (kvp.Value == id) {
                     go = kvp.Key;
                     return go;
                 } 
                 else
                     return null;
             }
         }

Answer 1

Answer by doublemax · Oct 08, 2016 at 04:18 PM

That code doesn't make much sense as it will only check the very first item in the dictionary.

Isn't this what you want?

 public static GameObject ReturnPrefab (ItemID id)
 {
   foreach (var kvp in pickUpDict)
   {
     if (kvp.Value == id)
       return kvp.Key;
   }
   return null;
 }

Add comment · Show 1 · Share

BoNaNa · Oct 08, 2016 at 07:40 PM 0

Share

Hey, yeah, just figured it out myself too. Just had to move the return up a level.

 public static GameObject ReturnPickUpPrefab (ItemID id) {
         GameObject go = null;
         foreach (var kvp in pickUpDict) {
             if (kvp.Value == id)
                 go = kvp.$$anonymous$$ey;
         }
         return go;
     }

"not all code paths return a value"

1 Reply

Welcome to Unity Answers

Follow this Question

Related Questions