• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by Mativve · Jan 12, 2017 at 02:08 PM · lightingscript.lightcarturn

Problem with turn left light

Hi! I have script to car light (part code below) and I have problem. When I press 'q' light to turnleft is on but if I want press 'q' again nothing happens. To turn off the light I need to click the 'e' and then turns off.

 //steer light//
         if (Input.GetKeyDown("q") && turnright == true)
         {
             turnleft = !turnleft;
             turnright = false;
         }
         else if (Input.GetKeyDown("q") && turnleft == false)
         {
             turnleft = !turnleft;
         }
 
         if (Input.GetKeyDown("e") && turnleft == true)
         {
             turnright = !turnright;
             turnleft = false;
         }
         else if (Input.GetKeyDown("e") && turnleft == false)
         {
             turnright = !turnright;
         }
 
         if (turnright)
         {
             turnSignalRIGHT.material = turnsignalON;
             turnSignalLEFT.material = turnsignalOFF;
             rightSignalON = true;
             leftSignalON = false;
         }
         else if(turnleft)
         {
             turnSignalRIGHT.material = turnsignalOFF;
             turnSignalLEFT.material = turnsignalON;
             rightSignalON = false;
             leftSignalON = true;
         }
         else
         {
             turnSignalRIGHT.material = turnsignalOFF;
             turnSignalLEFT.material = turnsignalOFF;
             rightSignalON = false;
             leftSignalON = false;
         }
 
         if(leftSignalON)
         {
             float floor = 0f;
             float ceiling = 1f;
             float emission = floor + Mathf.PingPong(Time.time*1.5f, ceiling - floor);
             turnSignalLEFT.material.SetColor("_EmissionColor",new Color(1f,1f,1f)*emission);
         }
         if(rightSignalON)
         {
             float floor = 0f;
             float ceiling = 1f;
             float emission = floor + Mathf.PingPong(Time.time* 1.5f, ceiling - floor);
             turnSignalRIGHT.material.SetColor("_EmissionColor",new Color(1f,1f,1f)*emission);
         }

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Pengocat · Jan 12, 2017 at 03:26 PM

You may want to use an enum instead of a lot of bools to keep track of things. Here is an example that you can work with.

     public Renderer turnSignalLeft;
     public Renderer turnSignalRight;
     public Material turnSignalOff;
     public Material turnSignalOn;
     enum Direction
     {
         neutral,
         right,
         left
     }
     Direction currentDirection = Direction.neutral;
 
     void Update()
     {
         // TurnSignal Left Toggle
         if (Input.GetKeyDown(KeyCode.Q))
         {
             // if direction is not Left set it to Left Otherwise set it to Neutral
             currentDirection = currentDirection != Direction.left ?
                 Direction.left : Direction.neutral;
         }
 
         // TurnSignal Right Toggle
         if (Input.GetKeyDown(KeyCode.E))
         {
             // if direction is not Right set it to Right Otherwise set it to Neutral
             currentDirection = currentDirection != Direction.right ?
                 Direction.right : Direction.neutral;
         }
         UpdateTurnSignal();
     }
 
     void UpdateTurnSignal()
     {
         switch (currentDirection)
         {
             case Direction.neutral:
                 SetTurnSignal(turnSignalRight, false);
                 SetTurnSignal(turnSignalLeft, false);
                 break;
             case Direction.right:
                 SetTurnSignal(turnSignalRight, true);
                 SetTurnSignal(turnSignalLeft, false);
 
                 break;
             case Direction.left:
                 SetTurnSignal(turnSignalRight, false);
                 SetTurnSignal(turnSignalLeft, true);
                 break;
             default:
                 break;
         }
     }
 
     void SetTurnSignal(Renderer signalRenderer, bool On)
     {
         float emission = Mathf.PingPong(Time.time, 1f);
         if (On)
         {
             if (signalRenderer.material != turnSignalOn)
             {
                 signalRenderer.material = turnSignalOn;
             }
             signalRenderer.material.SetColor("_EmissionColor", Color.white * emission);
         }
         else
         {
             if (signalRenderer.material != turnSignalOff)
             {
                 signalRenderer.material = turnSignalOff;
             }
         }
     }

The reason for all the material conditions is that it is quicker to check if a material is already set than to re-set it.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Mativve · Jan 12, 2017 at 07:50 PM 0
Share

Thank You SOOOOOOO much! It works perfectly :D :D

<3

avatar image Pengocat Mativve · Jan 12, 2017 at 08:04 PM 0
Share

You're welcome. I'm glad it helped.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

102 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Script to make specific parts of my object bright ? 0 Answers

I need a little help 0 Answers

Environment Lights 0 Answers

I have light problem in Unity 5.4.1f. Please help. 0 Answers

Why is my light darker than it should be? 1 Answer

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges