• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Yrjana · Feb 02, 2017 at 03:13 PM · cameracollisioncamera-movementclippingcalculation

MouseOrbitImproved camera distance seemingly inverted

I'm currently working on a game prototype where the camera is controlled by the commonly used MouseOrbitImproved script, however I've run into a problem concerning the camera's distance to the player when the player is approaching a surface.

It would seem that the calculation for the collision distance is inverted, I'll explain. When the camera is in-between the player and a wall,
wall|__[camera]---------(player)

if the player moves towards the wall, the moment the wall comes within the same distance as the camera, the camera zooms in on the player.
wall|___ [camera]-(player)

However, the closer the player gets to the wall, the further away from the player the camera positions itself.
wall|__[camera]----(player)

This leads to the camera clipping through walls and other geometry where it is undesired. [camera]--wall|(player)

If this isn't clear please ask more questions.

The MouseOrbitImproved C# code:

 using UnityEngine;
 using System.Collections;
 using System.Collections.Generic;
 
 [AddComponentMenu("Camera-Control/Mouse Orbit with zoom")]
 public class MouseOrbitImproved : MonoBehaviour
 {
 
 
     public Transform target;
     public float distance = 5.0f;
     public float xSpeed = 120.0f;
     public float ySpeed = 120.0f;
 
     public float yMinLimit = -20f;
     public float yMaxLimit = 80f;
 
     //public float distanceMin = .5f;
     //public float distanceMax = 15f;
 
     private Rigidbody rigidbody;
 
     float x = 0.0f;
     float y = 0.0f;
 
     // Use this for initialization
     void Start()
     {
         Vector3 angles = transform.eulerAngles;
         x = angles.y;
         y = angles.x;
 
         rigidbody = GetComponent<Rigidbody>();
 
         // Make the rigid body not change rotation
         if (rigidbody != null)
         {
             rigidbody.freezeRotation = true;
         }
     }
 
     void LateUpdate()
     {
         if (target)
         {
             x += Input.GetAxis("Mouse X") * xSpeed * distance * 0.02f;
             y -= Input.GetAxis("Mouse Y") * ySpeed * 0.02f;
 
             y = ClampAngle(y, yMinLimit, yMaxLimit);
 
             Quaternion rotation = Quaternion.Euler(y, x, 0);
 
             //distance = Mathf.Clamp(distance - Input.GetAxis("Mouse ScrollWheel") * 5, distanceMin, distanceMax);
             float dst = distance;
             RaycastHit hit;
             if (Physics.Linecast(target.position, rotation * new Vector3(0f, 0f, -distance) + target.position, out hit))
             {
                 dst -= hit.distance;
             }
             Vector3 negDistance = new Vector3(0.0f, 0.0f, -dst);
             Vector3 position = rotation * negDistance + target.position; 
            // where the problem likely occurs
 
             transform.rotation = rotation;
             transform.position = position;
         }
     }
 
     public static float ClampAngle(float angle, float min, float max)
     {
         if (angle < -360F)
             angle += 360F;
         if (angle > 360F)
             angle -= 360F;
         return Mathf.Clamp(angle, min, max);
     }
 }

What i'm looking for is a possible solution or help to pinpoint the problem in this code.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Yrjana · Feb 03, 2017 at 08:55 PM

While waiting for question verification i actually found a way around this problem by using the raycast's RaycastHit.point to set the cameras position if the raycast hit a surface. However, this still caused some serious clipping for the camera and would allow the player to look through walls. My next step was to prevent camera clipping as far as possible, and i did so using a lerp between the camera target and the RaycastHit.point in order to place the camera slightly above the surface.

In the game I'm working on the world contains a lot of geometry of different sizes, for example, a forest full of thin trees, and a rocky cliff face. The way the camera worked at this point was slightly seizure inducing while running through the forest, since the camera continued to change position whenever a tree got in between the camera and the player, but if the player approaches a large rock wall the camera still needs to behave this way. By using a Transform.Comparetag() check in the raycast I'm able to tag the geometry i want to block the camera so that it behaves this way only with them, but ignores all other collisions.

So, technically I've made an Improved MouseOrbitImproved, and i'll post the code here as soon as I've commented it properly.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Top down camera lock 2 Answers

Objects randomly dissapear in Game View 1 Answer

Rotating the camera over a period of time 1 Answer

Preventing camera clipping 2 Answers

Trying to fix bouncy linecast camera collision 1 Answer

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges