• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by grfdhfrgtj · Feb 09, 2017 at 12:39 PM · 2d gameclone

Pick up Items and Deep Copies

I tried to make a 2d plattformer with Pickup items. When the player collides with some Item, he is supposed to add this item into his inventory(array called items) and delete that item in the game. So i tried to make deep copies of that item into the inventory and failed to do so. The inspector shows the added items as "none" or missing" The other threads here didnt helped me too much. So this are the codes for that:

  public bool AddItem(Pickup item)
     {//returnt ob aufgehoben wird
         for (int i = 0; i < items.Length; i++)
         {
             if (item.Itemname == items[i].Itemname)
             {
                 if (items[i].Maxstack == items[i].Count)
                 {
                     items[i].Count = items[i].Count + item.Count;
                     return false;
                 }
                 else
                 {
                     items[i].Count = items[i].Count + item.Count;
                     return true;
                 }
                 
             }
            
         }
 
         Resize(items.Length + 1, ref items);
         items[items.Length -1] = item.Clone() as Pickup;
         return true;
     }
     private void Resize(int Size, ref Pickup[] itemss)
     {
 
         Pickup[] temp = new Pickup[Size];
         for (int c = 1; c < Mathf.Min(Size, itemss.Length); c++)
         {
             temp[c] = itemss[c].Clone()as Pickup;
         }
         itemss = temp;
     }
 

and the .clone();

    public object Clone()
             {
                 return MemberwiseClone();
             }

If it helps i can show my entire unity project aswell (Teamviewer or upload). I will back in a couple of hours.

Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image PizzaPie · Feb 09, 2017 at 01:56 PM 0
Share

What fields does the Pickup have? As long it contains ref types $$anonymous$$emberwiseClone() won't do the job as it shallow copies them. Check that out that should clear things out, and if you have time read all parts. Cheers. (Note: if you can't figure it out post the Pickup class for further help)

avatar image grfdhfrgtj PizzaPie · Feb 09, 2017 at 02:10 PM 0
Share

Pickup only contains rather simple types like in and float. Does string count as ref type? $$anonymous$$y pickup class inherites from my item class.

 public class Item:$$anonymous$$onoBehaviour {
 
     string _name = "Demoname";
     int _vkpreis = 1;
     int _kaufpreis = 2;
     int _maxstack = 1;//wieoft stackbar
     int _count = 1;
 
 
     public virtual void Setup(string itemname, int vkpreis, int kaufpreis, int maxstack, int count)
     {
         _name = itemname;
         _vkpreis = vkpreis;
         _kaufpreis = kaufpreis;
         _maxstack = maxstack;
         _count = count;
     }
 
     public object Clone()
     {
         return $$anonymous$$emberwiseClone();
     }
     public int Count
     {
         get { return _count; }
         set {
             if (value > _maxstack)
             {
                 _count = _maxstack;
             }
             else if (value < 0)
             {
                 _count = 0;
             }
             else
             {
                 _count = value;
             }
            
         }
     }
     public virtual void Use() { }
     public int $$anonymous$$axstack
     {
         get { return _maxstack; }
         set { _maxstack = value; }
     }
     public int $$anonymous$$aufpreis
     {
         get { return _kaufpreis; }
         set { _kaufpreis = value; }
     }
     public int Vkpreis
     {
         get { return _vkpreis; }
         set { _vkpreis = value; }
     }
     public string Itemname
     {
         get { return _name; }
         set { _name = value; }
     }
 }

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by grfdhfrgtj · Feb 09, 2017 at 10:08 PM

I solved the problem myself after some time. Hope it will help someone.. I threw the Clone-Funktion away and made myself a constructor. So i can use classA Acopy = new ClassA(A). Caution: The new Object triggers start and awake.

Thats my constructor:

 public Pickup(Pickup previousPickup)
     {
         onplayer = previousPickup.Onplayer;
         player = previousPickup.player;
         Count = previousPickup.Count;
         Maxstack = previousPickup.Maxstack;
         Kaufpreis = previousPickup.Kaufpreis;
         Vkpreis = previousPickup.Vkpreis;
         Itemname = previousPickup.Itemname;
     }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

96 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Auto generated blocks turning invisable? 2d game 1 Answer

[Solved] Problem with achieving rotation relative to current acceleration value 0 Answers

Does anybody know were i can download super metroid Super Nintendo assets and game templet? 2 Answers

how do you correct errors in a script? 0 Answers

2D game character stands or sometimes block by an invisible object? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges