• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by KiltedBear · Jun 21, 2011 at 01:00 PM · raycasthitfire ratemachinegun

Machine gun fire

Hey, I'm trying to get my gun to fire as a mac$$anonymous$$ne gun would. I can't see what is wrong with my code so I hope somebody here can!

 public float fireRate=0.5f;
 public float nextFire=0.0f;
 
 void Update () {
 if(gun.active)
 {
     if(Input.GetMouseButton(0)&&Time.deltaTime>nextFire){
         Debug.Log("shot fired");
         nextFire = Time.deltaTime+fireRate;
         audio.Play();
         Ray ray=Camera.main.ScreenPointToRay(shootingPoint);
         RaycastHit $$anonymous$$t=new RaycastHit();
         if(Physics.Raycast(ray,out $$anonymous$$t))
         {
             if($$anonymous$$t.collider.gameObject.tag=="barrel")
             ..........................

So that is the main code I believe is causing problems. Sometimes the gun fires as soon as it is picked up without pressing the mouse button. Perhaps Input.GetMouseButton(0)is wrong as i changed that from Input.GetMouseButtonDown(0)?

Comment

People who like this

0 Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image almo · Jun 21, 2011 at 01:50 PM 0
Share

the getmousebutton code looks fine to me.

2 Replies

· Add your reply
  • Sort: 
avatar image

Answer by Yanger_xy · Jun 21, 2011 at 03:12 PM

 if(Input.GetMouseButton(0)&&Time.deltaTime>nextFire)
 {
  ....
  ....
  nextFire = Time.deltaTime+fireRate;

.... } change it to t$$anonymous$$s: if(Input.GetMouseButton(0)&&Time.time>nextFire) { .... .... nextFire = Time.time+fireRate; .... }

GOOD LUCK!

Comment
KiltedBear

People who like this

1 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image

Answer by KiltedBear · Jun 21, 2011 at 05:17 PM

Thanks! it's repeating fire now but when I change the firerate it is still firing at the same rate no matter if i have 2.0f or 0.1f as the value!

Comment

People who like this

0 Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Chris D · Jun 21, 2011 at 05:39 PM 0
Share

Please use the comments field on the entry you're commenting on - the answer space should be reserved for solutions.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

5 People are following this question.

avatar image avatar image avatar image avatar image avatar image

Related Questions

Raycashit Variable make empty/null/clear? 1 Answer

RayCast to all directions 4 Answers

Null Reference Exception error when casting a ray from the camera out into the scene to hit an object 0 Answers

Adding an empty raycast hit to a list 1 Answer

Destroy gameobject by clicking it 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges