• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by Pan_Migo · Mar 25, 2017 at 08:52 AM · c#materialcolorrenderermemory

Changing material color creates a memory leak

I am creating a simple game, where multiple prefab clones exist, and when the mouse is over a specific clone, the material color of the clone changes.

     public Renderer[] c$$anonymous$$ldrenRenderers;
     private Color startColor;
     [SerializeField] private Material defaultMaterial;
     [SerializeField] private Material transparentMat; 
 
     // Use t$$anonymous$$s for initialization
     void Start () {
         GetComponents();
     }
 
     void GetComponents (){
               c$$anonymous$$ldrenRenderers = GetComponentsInC$$anonymous$$ldren<Renderer>    ();
              foreach(Renderer rend in c$$anonymous$$ldrenRenderers){
                 rend.material = setDefaultMat();
             }
             //both materials have the same color, so we chooce randomly the first.
             //startColor is the default material color that the turbine has.
             startColor = defaultMaterial.color;
     }
 
     public void UndamagedHighlightMat (){
         foreach(Renderer rend in c$$anonymous$$ldrenRenderers){
             rend.material = setDefaultMat();
             //rend.material.color = Color.cyan;
             rend.material.SetColor("_Color",Color.cyan);
         }
     }
 
     public void UndamagedDefaultMat (){
         foreach(Renderer rend in c$$anonymous$$ldrenRenderers){
             rend.material = setDefaultMat();
             rend.material.color = startColor;
         }    
         
     }
 
 public Material setDefaultMat(){
         return defaultMaterial;
     }

When the mouse is over the UndamagedHighlightMat () is called and when not the UndamagedDefaultMat ().

I have tried many t$$anonymous$$ngs like using sharedMaterial, but that changed every clone's material and not the specific one I wanted. Also, I found out that the problem was starting when the color was changing because the total number of objects in the profiler was increasing every time the material color changed.

So any help on the topic will be greatly appreciated, thank you in advance.

Comment

People who like this

0 Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Hellium · Mar 23, 2017 at 10:17 AM 0
Share

Have you tried a simple for loop instead of the for each ? How do you get the childrenRenderers ? Can you provide the setDefaultMat function ? (edit your question)

1 Reply

· Add your reply
  • Sort: 
avatar image

Answer by AurimasBlazulionis · Mar 25, 2017 at 02:55 PM

I would have a uninitialized material array. Let's say it is mats. Once you get the components, create althe array like t$$anonymous$$s: mats = new Material[c$$anonymous$$ldRenderers.Length]. Then use a simple for(int i =0; i < c$$anonymous$$ldRenderers.Length; i++) loop. Inside it set mats[I] to the default material's copy (replace that function with return (Material)Object.Instantiate(defaultMaterial);). Now do c$$anonymous$$ldRenderers[i].sharedMaterial = mats[i]. And when you want to change the color edit iterate through the mats array or just through sharedMaterial. If you do the latter, you might not even need the array. You will just need to modify the setDefaultMat function.

Comment

People who like this

0 Show 0 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

8 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Changing two different objects renderer colour 1 Answer

Material doesn't have a color property '_Color' 4 Answers

I'm trying to change a material, texture or color and it doesnt work 0 Answers

Changing Game Objects Color 1 Answer

Fade out a material that has a texture 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges