• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by abigaylebrooks · Apr 15, 2017 at 11:59 AM · c#unity 5scripting problemvariables

Referencing a non static variable from another script C# Unity

I'm trying to make a game where the player can chose the color of their ship. This process involves two scripts.

Script 1: "ColorPicker" The player will press one of four buttons to select their ship's color. This is recorded as a number in the variable "int color" This process does work, I can tell from the "Debug.Log". However this variable cannot be private or static or the code won't work.

 public Sprite[] shipcolors;
 public int color;

 public void ColorChoice(int color)
 {
     Debug.Log(color);
 }

Script 2: "PlayerControler" This script controls all the behaviors of the player's ship, among those what color it is.

  public Sprite[] shipcolors;
  public GameObject colorpicker;

  void Start () {
        ColorChoice();
  }

   public void ColorChoice()
     {
         colorpicker = GameObject.Find("ColorPicker");
         ColorPicker colorScript = colorpicker.GetComponent<ColorPicker>();
         print("Color Chosen: " + colorScript.color);
         if (shipcolors[colorScript.color])
         {
             this.GetComponent<SpriteRenderer>().sprite = shipcolors[colorScript.color];
         }
     }

From the print statement I see that the color variable is always set to zero no matter what button I press. I'm trying to figure out why "int color" saves in the "ColorPicker" script but doesn't transfer over to the "PlayerController" script.

If I manually enter the number into the color field while I am playing the game it will change the ship to the correct color but I want it to save from the buttons so the player doesn't have to enter the number manually. alt text I've tried putting the code from the "ColorPicker" script into the "PlayerController" script but I never got that to work. Any suggestions?

colorpicker.png (10.1 kB)
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by UnityCoach · Apr 15, 2017 at 12:58 PM

I don't see where you save the color int.

 public Sprite [] shipcolors;
 public int color;
 public void ColorChoice (int color)
 {
     Debug.Log (color); // here you debug the incoming color, not the member, you need to add
     color = color; // I would suggest you change one of the two names for disambiguation
 }
Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Commoble · Apr 15, 2017 at 03:23 PM 1
Share

I find this.color = color; disambiguous enough.

avatar image abigaylebrooks Commoble · Apr 16, 2017 at 03:32 AM 0
Share

Thanks @UnityCoach and @Commoble I added this.color = color and it works now

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

8 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

2 animations keep switching at a rapid pace 1 Answer

Refresh panel with prefab contained value from json that created using array 0 Answers

Object reference not set to an instance of an object 1 Answer

My sphere is not moving in the unity? 1 Answer

How can i look for collisions of the bulidngs in may array ? how can i use OnTRiggerEnter/exit ? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges