• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by iddkfa · Apr 19, 2017 at 10:13 AM · imagechangevalueset

[Improvement] change image based on set value

Hello everybody!
I'm very much new to Unity and wrote a little script to change an image based on a set value. The script itself works fine and i'm very happy with it. Looking at the amount of code though i wondered, if there's a more efficient way to achieve what i want it to do. Any suggestions or a little push into the right direction would be great.
Thanks in advance.

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEngine.UI;
 
 public class StarsDisplayScript : MonoBehaviour
 {
     public Image img1;
     public Image img2;
     public Image img3;
 
     int Skills;
 
     void Start()
     {
         // create random number between 1-5 (note: has to be changed to set value from persistent data later)
         Skills = Random.Range(1, 6);
         Debug.Log("the random number is: " + Skills);
 
         // change image (from Resources-folder) based on set value
         if (Skills == 1)
         {
             img1.sprite = Resources.Load<Sprite>("bronze_1");
         }
 
         else if (Skills == 2)
         {
             img1.sprite = Resources.Load<Sprite>("bronze_2");
         }
 
         else if (Skills == 3)
         {
             img1.sprite = Resources.Load<Sprite>("bronze_3");
         }
 
         else if (Skills == 4)
         {
             img1.sprite = Resources.Load<Sprite>("bronze_4");
         }
 
         else if (Skills == 5)
         {
             img1.sprite = Resources.Load<Sprite>("bronze_5");
         }
     }
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by mikelortega · Apr 19, 2017 at 10:15 AM

You can do this and delete all the ifs:

 img1.sprite = Resources.Load<Sprite>("bronze_" + Skills);
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image iddkfa · Apr 19, 2017 at 01:09 PM 0
Share

Thanks a lot, this is indeed way more efficient.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

(C#) Return Float Variable to previous value 1 Answer

Animation not recognizing small differences 0 Answers

Is it possible to change an images source image by code? C# 2 Answers

Why does Apple TV TV Top Shelf Image expect Image set? 0 Answers

Reduce ConstantForce value after specified time. WaitForSeconds()? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges