• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by ItzChris92 · May 06, 2017 at 01:14 PM · uirecttransformcollisionshealthbarlocalscale

Health Bar NullReferenceException

I am trying to integrate a health bar system into my project. I have already got a script on my enemy that causes damage to my player on collision, and player health goes down correctly (which I can see via Debug.Log). However, for some unknown reason the Health Bar transforms straight to 0, and the text shows 0% after just one hit from the enemy. Any help would be much appreciated.

Code for HealthBar:

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEngine.UI;
 
 public class PlayerUI : MonoBehaviour {
 
     public static int playerCurrentHealth;
     public Text gameOverText;
     public Image currentHealth; //Healthbar
     public Text healthPercentText; //Healthbar
 
     void Awake ()
     {
         playerCurrentHealth = gameObject.GetComponent<PlayerStats> ().playerMaxHealth;
     }
 
     private void Start()
     {
         UpdateHealthBar ();
     }
 
     public void UpdateHealthBar()
     {
         int healthPercent = playerCurrentHealth / (gameObject.GetComponent<PlayerStats> ().playerMaxHealth); 
         currentHealth.rectTransform.localScale = new Vector3 (healthPercent, 1, 1); //Needs fixing, health bar doesn't change!
         healthPercentText.text = (healthPercent * 100).ToString () + '%'; //Displays 100% but doesn't update!
     }
 }

Code for Enemy Damage:

     void OnCollisionStay(Collision attack) //Attacking the player
     {
         if (attack.gameObject.tag == "Player" && PlayerUI.playerCurrentHealth > 0 && Time.time > enemyAttackTimer) 
         {
             PlayerUI.playerCurrentHealth -= (gameObject.GetComponent<EnemyStats>().enemyDamage - GameObject.Find ("Player").GetComponent<PlayerStats> ().playerArmorRating);
             GameObject.Find ("Player").GetComponent<PlayerUI> ().UpdateHealthBar (); //This line is to call health bar function UpdateHealthBar
             Debug.Log ("You have been hit! Current Health: " + PlayerUI.playerCurrentHealth);
             enemyAttackTimer = Time.time + gameObject.GetComponent<EnemyStats> ().enemyAttackDelay;
         }
     }

EDIT: I had NullReferenceExceptions appearing on play, but had 2 of the same script attached to the player and one missing object references. Problem of health dropping straight to zero still persists.

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image PizzaPie · May 06, 2017 at 06:42 PM 0
Share

Line 25 you have the healthPercent declared as int but as you can see from the right side the number can't be an int as player$$anonymous$$axHealth will always be greater or equal to playerCurrentHealth, in case of player$$anonymous$$axHealth=playerCurrentHealth the healthPercent will be 1 but when playerCurrentHealth is less than maxHealth the number gonna be something like 0.12321 so the value will be turned to 0 as ints don't contain decimals , so the value of healthPerc gonna be 0 or 1. To fix it use this:

 float healthPercent = (float)playerCurrentHealth /(float) (gameObject.GetComponent<PlayerStats>().player$$anonymous$$axHealth);

the casting on the right side is not required if the numbers are already floats

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by ItzChris92 · May 06, 2017 at 02:08 PM

I have absolutely no idea what was causing this! I re-wrote the code, and checked with the code posted above. No difference at all, except now it works?? Not complaining, but I'm bewildered... What could have caused that?

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

140 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Custom Slider Shapes causing fill to break. 0 Answers

Proper way to wait until dynamically added children of a layout group are rendered 0 Answers

How can I position a rect transform inside another via code? 0 Answers

Rect Transform limits vs position and size 1 Answer

Place GameObject's rect 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges