I'm having more problems accessing a variable from another script in c#

Question

ok guys this is what I have pertaining too this specific function except I have a variable called isstuned saved in the file PlayerScript and it is marked as a public int variable

 void Update () 
     {
         PlayerScript Pscript = GetComponent<PlayerScript>();
         if(Pscript.isstuned == 0)
         {

this is the new compile error I am getting when I hit play to test the game

NullReferenceException: Object reference not set to an instance of an object PlayerAnimation.Update () (at Assets/Scripts/PlayerAnimation.cs:24)

my question is how do I set it to an instance of an object? or is that not what I am supposed to be doing at all?

Answer 1

Best Answer

Answer by aldonaletto · Jul 10, 2011 at 11:47 PM

The problem is in the PlayerAnimation.cs script, at line 24. What is in that line? if(Pscript.isstuned == 0) ? If so, the problem is that GetComponent is not finding the script PlayerScript, and when you try to use isstuned Unity complains because Pscript == null. If PlayerScript is in another object, you must first find that object, then get the script. If the PlayerScript is attached to the Player object:

 void Update () 
 {
     GameObject obj = GameObject.Find("Player");
     PlayerScript Pscript = obj.GetComponent<PlayerScript>();
     if(Pscript.isstuned == 0)

The Player object must not be a child of other object, or Find will not find it.

Add comment · Show 3 · Share

deeredman1991 · Jul 11, 2011 at 12:06 AM 0

Share

the game object containing the variable isstuned is the parent of the object with the script I'm working on :)

deeredman1991 · Jul 11, 2011 at 12:12 AM 0

Share

nvm I figured it out :D ty ^_^ ur awesome dude you've answered 3 of my questions and gotten correct answer on all of them...you've always explained things the simplest and effective way possible...keep it up :D

sdgd · Jan 19, 2013 at 03:35 AM 0

Share

finally I found the correct answer for the how to access other variables in other scripts after 3 hours searching through all Q/A of how to access other variables in other scripts

you answered my Q 2 times 1. actively 2. time passively

I'm going to make a Q to make a better manual for this Question

I would thumbs up if I could tho :)

Answer 2

GetComponent will return null when there is no such Component on the GameObject. Are you sure that you have the PlayerScript attached to the same GameObject as this script above?

If you want them on seperate GOs you have to call GetComponent on the right GameObject.

eg.

 public GameObject playerObject;

 void Update () 
 {
     PlayerScript Pscript = playerObject.GetComponent<PlayerScript>();
     if(Pscript.isstuned == 0)
     {

In this case you have to assign the other GameObject to the public variable playerObject in the inspector. It would be easier to directly setup a reference to the PlayerScript.

 public PlayerScript Pscript;

 void Update () 
 {
     if(Pscript.isstuned == 0)
     {

Like in the first example just drag the playerobject onto the variable. Unity will automatically link the PlayerScript instance (if there is one) from that GameObject to the variable.

If the objects are all instantiated at runtime you have to find the right one either by saving the created instance somewhere when you instantiate it, or use one of the search functions like GameObject.Find / FindObjectOfType / ...

I'm having more problems accessing a variable from another script in c#

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions