• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by yaezah · Oct 13, 2017 at 09:45 PM · instantiatevariableupdatefunctionngui

How to prevent object (bullet) from instantiating twice ? (It instantiates once for tapping the screen, and once more when beginning to hold touch on screen) ?

I'm trying to make my game have the option of holding down the screen for auto-firing of bullets, and if the player wants to tap the screen , the bullets should also instantiate as fast as they can tap. I have the auto-fire script set like this:

     bool fire;
     GunControl other;
     GameObject gun;
     float fireRate;
     float lastShot;
 
     
     void Start () {
 
         gun = GameObject.Find("Gun"); //Finds Gun Gameobject
         other = (GunControl)gun.GetComponent(typeof(GunControl)); //Get GunControl Script From Gun
         fireRate = 0.25f;
         lastShot = 0.0f;
     }
     
     
     void Update () {
 
         if (fire == true)
         {
            FireRate(); //call FireRate function below
         }
     }
 
     void FireRate()
     {
         if (Time.time > fireRate + lastShot) //if Time passed is more than fireRate set above + Seconds since last shot , fire again..
         {
             other.Fire();
             lastShot = Time.time;
         }
     }
 
 
     public void OnPress(bool isPressed)
     {
         if (enabled)
         {
             if (isPressed)
             {
                 fire = true;
             }
             else
             {
                 fire = false;
             }
         }
     }
 
     public void OnClick( )
     {
         // ??????????????
     }
 
 }

My question is how to prevent that first shot from calling both the fireRate function and also the OnClick at the same time... Because once I tap it shoots two bullets, but if i continue to hold on that tap it'll just do the auto-fire.

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image yaezah · Oct 13, 2017 at 10:25 PM 0
Share

I think I got it , here's code if anyone has a similar problem:

Added FireSingle Function

     bool fire;
     GunControl other;
     GameObject gun;
     float fireRate;
     float lastShot;
 
     bool firetap;
 
     
     void Start () {
 
         gun = GameObject.Find("Gun"); //Finds Gun Gameobject
         other = (GunControl)gun.GetComponent(typeof(GunControl)); //Get GunControl Script From Gun
         fireRate = 0.25f;
         lastShot = 0.0f;
     }
     
     
     void Update () {
 
         if (fire == true)
         {
            FireRate(); //call FireRate function below
         }
     }
 
     void FireRate()
     {
         if (Time.time > fireRate + lastShot && firetap == false) //if Time passed is more than fireRate set above + Seconds since last shot , fire again..
         {
             other.Fire();
             lastShot = Time.time;
         }
         else
         {
             FireSingle();
         }
     }
 
 
     public void OnPress(bool isPressed)
     {
         if (enabled)
         {
             if (isPressed)
             {
                 fire = true;
             }
             else
             {
                 fire = false;
             }
         }
     }
 
     public void OnClick( )
     {
         firetap = true;
     }
 
     void FireSingle()
     {
         if (firetap == true)
         {
             other.Fire();
             firetap = false;
             lastShot = Time.time;
         }
     }
 
 }

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by SoulRider · Oct 14, 2017 at 12:49 PM

Generally you want to know when a button has been released for firing purposes, so you would trigger your initial bullet when the button is released. This enables you to do your auto fire, and the block the OnRelease from firing a bullet if you don't want that to happen.

Psuedocode:

 Update(){
     if not button.waspressedlastframe and button.ispressedthisframe
         lastShot = 0f;
     if button.waspressedlastframe and button.ispressedthisframe
         if lastshot + firedelay < time
             fire;
             lastshot = time;
     if button.waspressedlastframe and not pressedthisframe
         if lastshot = 0f
             fire;
 }


Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

94 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Update() doesnt call method or modify values 1 Answer

summing up items price in runtime 1 Answer

Calling a variable 2 Answers

Having code fire once in update function? 2 Answers

calling function once? 3 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges