• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
This question was closed Feb 19, 2018 at 06:41 AM by Wokarol for the following reason:

Other

avatar image
Question by Wokarol · Oct 30, 2017 at 09:45 PM · c#scripting problemguinewbielearning

Hearth based health system help

I'm learning Unity, and I'm new to C#.
It's my first fully self made script and I want to know how to make it better and more optimized.
I t$$anonymous$$nk I should do somet$$anonymous$$ng with part where script is looking for Animator in every C$$anonymous$$ld.

As well as I want to add option to show two or more indicators, like health and s$$anonymous$$eld in one "icon's bar"
Script


I apologize for mistakes, I'm not American.

Comment

People who like this

0 Show 21
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image AidanHorton · Oct 31, 2017 at 12:37 PM 1
Share

You've attached a '.unitypackage' file, you should instead attach your C# file.

avatar image Wokarol AidanHorton · Oct 31, 2017 at 09:37 PM 0
Share

@AidanHorton // I attached .unitypackage because it contains C# script, simple test assets and example scene

avatar image AidanHorton Wokarol · Nov 02, 2017 at 09:18 AM 0
Share

I don't have access to unity for a while, so attaching a C# script would have meant I could take a look at just the script now (since I have visual studio), but that's my fault for not mentioning that in my previous comment. Anyway it sounds like someone else with access to the full project would be more useful to you, good luck :)

Show more comments
avatar image unity_43Epnxgw7CpITw · Nov 02, 2017 at 09:28 AM 0
Share

I would have checked the script out but sorry I'm not gonna open unitypackages.

avatar image Wokarol unity_43Epnxgw7CpITw · Nov 03, 2017 at 06:00 PM 0
Share

I understand it in some way, but why? Is it possible to put some sort of virus in .unitypackage file?

avatar image MacDx Wokarol · Nov 03, 2017 at 06:19 PM 0
Share

If you understand it then you know why. Some sort of virus? What's a virus other than a computer program and what's a C# file? It's basic online etiquette lol. Even if you don't know if it is possible to put a virus in a unity package, you don't open unknown files just like that, it is internet common sense. Why ask people to download and put your files in their computer when you could very well paste the code in this thread or put it on pastebin or anything like that. Of course people will be suspicious. Lol. Again, internet common sense dude.

Show more comments
avatar image connorwforman · Nov 06, 2017 at 04:20 PM 0
Share

Welcome to Unity! Most new developers share the same mistake that you did. Writing the script. On answers.unity3d.com, there is a feature where you can copy/paste your script to make it readable. Here is a tutorial:

This bar on the top has a feature which is the alt text button. Click that, then a text box will come up and then you can paste your script there. Hope this helps!

alt text

screenshot-2017-11-06-at-111654-am.png (4.3 kB)
screenshot-2017-11-06-at-111841-am.png (199 B)
avatar image Hellium connorwforman · Nov 06, 2017 at 04:32 PM 0
Share

@connorwforman : Even if you have been on Unity Answers for more than 6 months, and you know how to use the "101010" button, you still do not know when to post an answer or comment.

avatar image AidanHorton · Nov 07, 2017 at 10:13 AM 0
Share

The script in general seems very well made. There's one or two small logic errors, and areas which could probably be improved performance wise, but apart from that it's very good for your first self-made script.

Good practice would be to mark all of the serialized variables as private.

A more efficient way of getting the current children would be using a list (https://msdn.microsoft.com/en-us/library/6sh2ey19(v=vs.110).aspx), so instead of getting 'transform.getchild' you can get the child which would be stored in the list (this assumes you only add children in this script). Transform.child can be quite heavy so you should figure out a way to add and remove the correct amount of children from the list using the logic you already have.

Also the if statement around the first for loop is redundant, the for loop wont fire if childcount is greater than maxvalue because the 'i' would be greater than maxvalue-childcount.

The final thing I see is that you are not casting 'clone' to a gameobject, it would create an error if you tried to use it, so do this instead:

 GameObject clone = (GameObject)Instantiate(childPrefab, transform);
avatar image Wokarol AidanHorton · Nov 07, 2017 at 10:23 AM 0
Share

Thanks, I'll try lists. Do you have any tips how to make this script able to handle multiple "health types" (like live and shield)?

avatar image AidanHorton Wokarol · Nov 07, 2017 at 10:53 AM 0
Share

I'm going to need more detail on what exactly you need the script to do - I need specific detail here so I can help you with this

Show more comments

0 Replies

  • Sort: 

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

454 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Pause menu done exactly according to tutorial doesen't work 2 Answers

Location Does Not Change 1 Answer

Using downloaded image as UI Image's source image? 1 Answer

Parse issue, despite the data being pulled from database 2 Answers

How to make a power meter going from green to red signifying the power of the shot by stopping the bar using the space bar?,How to make a power meter that stops by pressing space button 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges