Generator script not working due to lack of differentiation?

Question

Hello, I have a generator script that basically generates the bulk of the objects in my game, but It is not differentiating between generating 100 stone or 100 grass, it simply generates about 50 of both. Thus far I have been unsuccessful of finding out how to deal with t$$anonymous$$s due to me not being good at using multiple arrays in cooperation with each other. Thanks.

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class EcoGeneraterScript : MonoBehaviour {
 
     public GameObject Map;
     public GameObject[] GeneratedObjects;
 
     public int[] NumberofObjectsToGenerate;
 
     private float Cord_X = 0;
     private float Cord_Z = 0;
 
     private bool CanGenerate = true;
 
     void Update () {
         for ( int i = 0; i < NumberofObjectsToGenerate.Length; i++) {
             foreach (GameObject GeneratedGameObject in GeneratedObjects) {
                 if (NumberofObjectsToGenerate[i] > 0 && CanGenerate == true) {
                     Instantiate(GeneratedGameObject, new Vector3(Cord_X, 0.5f, Cord_Z),Quaternion.identity);
                     NumberofObjectsToGenerate[i] -= 1;
                     Cord_X += 1;
                         if (Cord_X >= 100) {
                             Cord_X = 0;
                             Cord_Z += 1;
                             if (Cord_Z >= 100) {
                                 CanGenerate = false;
                         }
                     }
                 }
             }
         }
     }
 }

Answer 1

Best Answer

Answer by MacDx · Dec 13, 2017 at 03:08 PM

The logic of your foor loops is not correct. There is no loop in your code that iterates the number of times indicated by each entry in your NumberofObjectsToGenerate array. What you're doing right now is instantiating one of every object in your GeneratedObjects array for every entry in your NOTG (yeah that's what I'll call NumberofObjectsToGenerate, from now on). So if your NOTG array has 7 entries then your code will spawn 7 of each (unless of course the condition of CanGenerate is false).

 //Here's an assumption I'm making about your arrays since you didn't described their contents
 //    Array Position    Array Name    Entry       Array Name        Entry
 //              0           NOTG       50        GeneratedObjects   Obj1
 //              1           NOTG       100      GeneratedObjects   Obj2
 //So I'm assuming that what you want to do is link the arrays by their position, meaning that
 //you want to spawn 50 of Obj1 and 100 of Obj2 
 //since the position in their respective array is the same
 //So to do that I'd do somet$$anonymous$$ng like t$$anonymous$$s:
 void Update(){
     for(int i = 0; i<NOTG.Length ; i++){
         //Copy the number since for some reason you want to decrease it w$$anonymous$$le iterating
         //Know that modifying an array or any collection w$$anonymous$$le iterating over it,
         //isn't always the best idea
         int numberOfInstances = NOTG[i];
         for(int j = 0; j<numberOfInstances; j++){
             Instantiate(GeneratedObjects[i], new Vector3(Cord_X, 0.5f, Cord_Z),Quaternion.identity);
             NOTG[i] --;
         }
     }
 }

And that's it. A couple of notes. First, never do t$$anonymous$$s type of boolean comparison CanGenerate == true, it is completely redundant, like multiplying a number by 1, there is no logical reason to do it. Second, you don't need to check if the number inside NOTG is greater than zero (NumberofObjectsToGenerate[i] > 0) because if you will use that number to iterate, but it is zero, there will simply be zero iterations and the code won't spawn anyt$$anonymous$$ng, it is a bit redundant to do that check too. And finally you can see that I didn't include the CanGenerate stuff, well that's because I don't completely understand where you were going with that so I didn't want to mess with it, you can include that part yourself.

Hope t$$anonymous$$s helps!

Edit: Corrected the Instantiate line

1 Show 6 · Share

$$anonymous$$ · Dec 14, 2017 at 01:07 AM 0

Share

CanGenerate was supposed to be a public variable, I don't remember why I set it to private. Also, I don't see where the foreach statement comes in to play.

MacDx $$anonymous$$ · Dec 14, 2017 at 02:40 AM 0

Share

Also, I don't see where the foreach statement comes in to play.

You don't need the foreach that's the whole point of what I said, the foreach logic won't work here because you need to iterate through the NOTG array with a for and then a second for to iterate the number of times each entry in NOTG dictates. There is absolutely no need for a foreach here, besides a foreach will not give you a position in the array, which is essential to this problem since you want to link both arrays by position. The code I posted produces 50 of the first and 100 of the second. But it looks like what I'm saying is falling to deaf ears, since you went and did the same (having the foreach, which will obviously not work).

$$anonymous$$ MacDx · Dec 14, 2017 at 03:17 AM 0

Share

The problem was that I was confused at GeneratedGameObject being used to instantiate when it has not even been created by the foreach statement, but I figured out that I had to use GeneratedObjects[i].

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class EcoGeneraterScript : MonoBehaviour {
 
     public GameObject[] GeneratedObjects;
 
     public int[] NumberofObjectsToGenerate;
 
     public float MapWidth;
     public float MapLength;
 
     private float Cord_X = 0;
     private float Cord_Z = 0;
 
     void Update () {
         for (int i = 0; i < NumberofObjectsToGenerate.Length; i++) {
             int NumberOfInstances = NumberofObjectsToGenerate [i];
             for (int j = 0; j<NumberOfInstances; j++){
                 if (NumberofObjectsToGenerate[i] > 0 && Cord_Z < MapLength) {
                     Instantiate(GeneratedObjects[i], new Vector3(Cord_X, 0.5f, Cord_Z),Quaternion.identity);
                     NumberofObjectsToGenerate[i] -= 1;
                     Cord_X += 1;
                     if (Cord_X >= MapLength) {
                         Cord_X = 0;
                         Cord_Z += 1;
                         if (Cord_Z >= MapLength) {
                         }
                     }
                 }
             }
         }
     }
 }

Show more comments

$$anonymous$$ · Dec 14, 2017 at 01:17 AM 0

Share

This code should be slightly better, but it still does not generate 50 of on thing and 100 of another, just 150 of both.

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class EcoGeneraterScript : MonoBehaviour {
 
     public GameObject[] GeneratedObjects;
 
     public int[] NumberofObjectsToGenerate;
 
     public float MapWidth;
     public float MapLength;
 
     private float Cord_X = 0;
     private float Cord_Z = 0;
 
     void Update () {
         for (int i = 0; i < NumberofObjectsToGenerate.Length; i++) {
             int NumberOfInstances = NumberofObjectsToGenerate [i];
             for (int j = 0; j<NumberOfInstances; j++){
             foreach (GameObject GeneratedGameObject in GeneratedObjects) {
                 if (NumberofObjectsToGenerate[i] > 0 && Cord_Z < MapLength) {
                     Instantiate(GeneratedGameObject, new Vector3(Cord_X, 0.5f, Cord_Z),Quaternion.identity);
                     NumberofObjectsToGenerate[i] -= 1;
                     Cord_X += 1;
                     if (Cord_X >= MapLength) {
                         Cord_X = 0;
                         Cord_Z += 1;
                             if (Cord_Z >= MapLength) {
                             }
                         }
                     }
                 }
             }
         }
     }
 }

Generator script not working due to lack of differentiation?

1 Reply

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions