How do i destroy whole army?

Question

Hello everybody,im real newbie and sorry about that.

I m having a trouble with destroying enemies.I mean i can kill(destroy) everybody while throwing knife.But when i want to kill with melee attacks,im having this;

"MissingReferenceException: The object of type 'GameObject' has been destroyed but you are still trying to access it.Your script should either check if it is null or you should not destroy the object."

On the player side its my melee attack function:

 IEnumerator attack()
     {
         if (isGrounded && move == 0 && meleeAttackTimer)
         {
             meleeAttackTimer = false;
             if (!meleeAttackTimer)
                 isAttacking = true;
             if (canDoMeleeDamage)
             {
                 foreach (GameObject enemy in enemies)
                 {
                     this.enemy = enemy.GetComponent<Enemy>();
                     if (this.enemy.isAgainstPlayer)
                     {
                         this.enemy.takeDamage(meleeDamage);
                         Debug.Log("attacked");
                         yield return new WaitForSeconds(0.17f);
                         isAttacking = false;
                         if (!isAttacking)
                             yield return new WaitForSeconds(0.39f);
                         meleeAttackTimer = true;
                     }
                 }
             }
             else
             {
                 isAttacking = true;
                 yield return new WaitForSeconds(0.17f);
                 isAttacking = false;
                 if (!isAttacking)
                     yield return new WaitForSeconds(0.39f);
                 meleeAttackTimer = true;
             }
         }
     }

And it is die and takeDamage function from enemy side:

  public void takeDamage(int damage)
     {
         hp -= damage;
         if (hp <= 0)
         {
             StartCoroutine(die());
         }
     }
 IEnumerator die()
     {
         rigidBody2D.velocity = new Vector2(0, 0);
         isDead = true;
         yield return new WaitForSeconds(0.5f);
         Destroy(gameObject);
     }

How can i get rid of this situation? Thanks for supports.

Answer 1

@Ectogenesis I see the issue now. What is happening is your forloop is finding all gameobjects and is checking for your enemiy script which is probably missing. What you need to do is search game objects differently so only enemies are picked. You can revert back to what you had but keep the yield after the loop as I think it will work in a coroutine. If this is correct please mark it as your answer :)

Try this.

 IEnumerator attack()
           {
               if (isGrounded && move == 0 && meleeAttackTimer)
               {
                   meleeAttackTimer = false;
                   if (!meleeAttackTimer)
                       isAttacking = true;
                   if (canDoMeleeDamage)
                   {
                       foreach (var enemy in FindObjectsOfType<Enemy>())
                       {
                        
                           if (enemy.isAgainstPlayer)
                           {
                               enemy.takeDamage(meleeDamage);
                               Debug.Log("attacked");
                              
                           }
                       }
                        yield return new WaitForSeconds(0.17f);
                        isAttacking = false;
                        if (!isAttacking)
                        yield return new WaitForSeconds(0.39f);
                        meleeAttackTimer = true;
                   }
                   else
                   {
                       isAttacking = true;
                       yield return new WaitForSeconds(0.17f);
                       isAttacking = false;
                       if (!isAttacking)
                           yield return new WaitForSeconds(0.39f);
                       meleeAttackTimer = true;
                   }
               }
           }

Answer 2

Answer by Ectogenesis · Feb 28, 2018 at 06:34 PM

Delete the yields on both sides and still same. foreach (GameObject enemy in enemies) { this.enemy = enemy.GetComponent<Enemy>(); if (this.enemy.isAgainstPlayer) { this.enemy.takeDamage(meleeDamage); Debug.Log("attacked"); } The error line is this; this.enemy = enemy.GetComponent();

Add comment · Show 1 · Share

browne11 · Feb 28, 2018 at 06:52 PM 0

Share

You should convert this to a comment as you listed it as an answer. Click the cogwheel on the right corner.

How do i destroy whole army?

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions