• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by JanWdm · Mar 08, 2018 at 09:30 PM · c#child objectvirtualoverridereturn type

change return type of virtual method

Hey, I have a Database which contains every item in the game.

I have a base class Item

         public class Item: ScriptableObject 
         {
         private string itemName;
         public virtual Item ReturnItem() 
         {
             return this;
         }
         }

Several classes like Weapon derive from Item.

             public class Weapon: Item
             {
             private int damage;
             public override Item ReturnItem() 
             {
                 return this;
             }
             }

Is it possible to make the override method ReturnItem return the childclass(Weapon) instead of just the item?

Or is there any other way to determine what childclass the Item belongs to aside from casting it to a weapon and checking if it threw a error

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by ShadyProductions · Mar 08, 2018 at 10:06 PM

That's not possible, but you can know which type it is:

 List<Item> items = new List<Item>();
 items.Add(new Weapon());
 items.Add(new Item());
 
 foreach (var item in items)
 {
     Debug.Log(item.GetType().Name);
 }

If you made Item an abstract class you could do something like this instead:

 public abstract class Item
 {
     public virtual T GetItem<T>()
     {
         if (GetType() == typeof(T))
             return (T)Convert.ChangeType(this, typeof(T));
         return default(T);
     }
 }

and then you could use it like this without having to overwrite the method in other classes (still optional thats why I left it virtual):

 List<Item> items = new List<Item>
 {
     new Weapon(),
     new Potion()
 };
 
 for (int i=0; i < items.Count; i++)
 {
     var potion = items[i].GetItem<Potion>();
     if (potion == null) continue;
     Console.WriteLine("Item at index " + i + " is a potion!");
 }

This way you get the potion object as a potion type aswel.

Comment
Add comment · Show 4 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Bunny83 · Mar 09, 2018 at 12:30 AM 2
Share

There's no need for a virtual method or reflection based casting. You can simply do:

 public abstract class Item
 {
     public T GetItem<T>() where T : Item
     {
         return this as T;
     }
 }

Though this would make the method itself pretty pointless ^^. So your line:

 var potion = items[i].GetItem<Potion>();

could be replaced with

 var potion = items[i] as Potion;

and you get the same behaviour. Also note that your reflection based type check does not work with inheritance. For example if you have an inheritance chain like this Item <-- Weapon <-- AssaultRifle when using

 GetItem<Weapon>()

It would not return an AssaultRifle even it is a Weapon. If you do a reflection based type check in almost all cases you want to use IsAssignableFrom like this:

 if (typeof(T).IsAssignableFrom(GetType()))


avatar image JanWdm Bunny83 · Mar 09, 2018 at 01:46 AM 0
Share

Thanks that looks a little cleaner and easier to understand then the previous answer. Just another short question is there any benefit of using var ins$$anonymous$$d of Potion? Or is it just a convenience thing since its faster to write.

avatar image Bunny83 · Mar 09, 2018 at 12:41 AM 1
Share

Oh and if you have a collection of "Item"s (an array or List) you can just use the Linq extension method OfType. It will filter the collection and only return the elements which could be casted into the specified type. So a simple foreach loop like this would work:

 foreach(Potion p in items.OfType<Potion>())
 {
     
 }

If the array items does not contain any Potion the loop won't run at all. Of course if you need an element index this doesn't work since we just work with IEnumerables here. To use the OfType extension method you have to add a using System.Linq; at the top.

avatar image JanWdm · Mar 09, 2018 at 01:13 AM 0
Share

Thanks that is exactly what i needed!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

462 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Get Collider of Child Object? 1 Answer

Knowing when a Childobject is hit by Raycast 0 Answers

Why does my Override Controller dosen't change the Animation Clip? 1 Answer

Using Child Object To Control Parent 0 Answers

Can't find Animator State/Invalid Layer Index in child object inside prefab 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges