• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by asperix · May 17, 2018 at 09:13 AM · c#unity 5programmingfunctionbool

Bool function not running when called from other script

Im making my first Vr game with the HTC Vive. I dont really get the whole ClickedEventArgs thing so i made my own script to check for button-pressed on the controller. but i have some problems with some of the functions. here is the relevant code:

 void Update () {
     triggerPosition = GetTriggerPos();
 }
 void LateUpdate(){
     tmptriggerpos=triggerPosition;
 }
 
 public float GetTriggerPos(){
     return controller.GetAxis(Valve.VR.EVRButtonId.k_EButton_SteamVR_Trigger).x;
 }
 public bool TriggerDown(){
     Debug.Log("TriggerDown");
     if(tmptriggerpos!=1&&triggerPosition==1){
         return true;
     }
     return false;
 }
 public bool TriggerUp(){
     Debug.Log("TriggerUp");
     if(tmptriggerpos==1&&triggerPosition!=1){
         return true;
     }
     return false;
 }
 public bool TriggerHold(){
     if(triggerPosition==1){
         return true;
     }
     return false;
 }

Now, if i run any of these functions from the Update function everything works as intended. But if i run TriggerUp or TriggerDown from another script, it doesn't even print. Im pretty positive that the function is not actually called. The TriggerHold function works perfectly when called from other scripts.

for instance, if i do this in another script it works:

 if(controller.TriggerHold()){
     Debug.Log("TriggerHeld");
 }

but if i do this:

 if(controller.TriggerDown()){
     Debug.Log("TriggerDown");
 }

it doesnt work. why???

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by asperix · May 17, 2018 at 01:02 PM

Nevermind! i figured it out. the script was run after the other script. just had to add [DefaultExecutionOrder(-1000)] at the start

=)

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by NoDumbQuestion · May 17, 2018 at 09:27 AM

@asperix Your update:

  void LateUpdate(){
      tmptriggerpos=triggerPosition;
  }

Your If condition

 if(tmptriggerpos!=1&&triggerPosition==1){
          return true;
      }

tmptriggerpos == triggerPosition == 1

It always false

Comment
Add comment · Show 7 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image asperix · May 17, 2018 at 09:46 AM 0
Share

But isnt tmptriggerpos the position the trigger was in last frame? thats why i put it in LateUpdate() so it was set at the end of the frame, and thus would be the position the trigger was is at the last frame.

avatar image asperix · May 17, 2018 at 09:46 AM 0
Share

have i completely missed something?

avatar image eidursveinn · May 17, 2018 at 10:10 AM 0
Share

LateUpdate is called after all calls to Update, but both Update and LateUpdate are called every frame.

That's why if you run:

 void Update () {
      triggerPosition = GetTriggerPos();
  }
  void LateUpdate(){
      tmptriggerpos=triggerPosition;
  }

Both triggerPosition and tmptriggerpos will be set to the same value from GetTriggerPos() and will therefore always evaluate to false in the TriggerUp function.

avatar image asperix eidursveinn · May 17, 2018 at 11:57 AM 0
Share

Yes, but firstly i set triggerPosition. then i run all the code, and functions. then, at the end of the script, right before it cuts to next frame, i make a copy og triggerPosition in tmptriggerpos. then in the next frame, the first thing i do is set the triggerPosition to the current position of the trigger, and then i run all the functions and so on. but all of them are run with the current position of the trigger in triggerPosition, and the position of the trigger i recorded last frame in tmptriggerpos. am i wrong?

avatar image NoDumbQuestion asperix · May 17, 2018 at 11:59 AM 0
Share

Why dont you add a debug in function to check if both of them really 1 == 1

Show more comments
Show more comments

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

530 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Add Special Events for Skills 1 Answer

Variable Assigned Error along with "Name "" Not Assigned in Current Context 0 Answers

Need help in typing project 0 Answers

Unity destroy 1 of 2 exactly the same GameObjects with 1 script 1 Answer

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges