• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by HeliumB · May 21, 2018 at 05:35 PM · prefabdestroyclonedestroy-clones

Destroy(clone) not destroying the instantiated prefab

I'm trying to destroy an instantiated prefab but it isn't doing anything.

Here's my code:

    void Update () {
 
         if (P1notSpawned)
         {
             GameObject player1 = (GameObject)Instantiate(P1, spawnPoint1.position, spawnPoint1.rotation);
             P1notSpawned = false;
 
         }
 
         if (P2notSpawned)
         {
             GameObject player2 = (GameObject)Instantiate(P2, spawnPoint2.position, spawnPoint2.rotation);
             P2notSpawned = false;
 
         }
 
         if (P1Life <= 0)
         {
 
             Destroy(player1);
 
             P1Life = 5;
             for (int i = 0; i < p1Sticks.Length; i++)
             {
                 if (P1Life > i)
                 {
                     p1Sticks[i].SetActive(true);
                 }
                 else
                 {
                     p1Sticks[i].SetActive(false);
                 }
             }
 
         }
 
         if (P2Life <= 0)
         {
             Destroy(player2);
 
             P2Life = 5;
             for (int i = 0; i < p2Sticks.Length; i++)
             {
                 if (P2Life > i)
                 {
                     p2Sticks[i].SetActive(true);
                 }
                 else
                 {
                     p2Sticks[i].SetActive(false);
                 }
             }
         }
     }

The Destroy(player1) and Destroy(player2) aren't actually destroying the instantiated prefabs.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by TreyH · May 21, 2018 at 05:53 PM

You seem a little confused about scope. Those references do not exist as you've written them and I doubt this compiles at all.

Before you continue with Unity, you should check out a few of the official tutorials. These help familiarize people with C# and Unity in general, which sounds like you might want to consider:
https://unity3d.com/learn/tutorials/topics/scripting/coding-unity-absolute-beginner


For your situation, you need to preserve those references:

 private GameObject player1;
 private GameObject player2;
 
 void Update () {
 
     if (P1notSpawned)
     {
         this.player1 = (GameObject)Instantiate(P1, spawnPoint1.position, spawnPoint1.rotation);
         P1notSpawned = false;
     }
 
     if (P2notSpawned)
     {
         this.player2 = (GameObject)Instantiate(P2, spawnPoint2.position, spawnPoint2.rotation);
         P2notSpawned = false;
     }
 
     if (P1Life <= 0)
     {
         Destroy(this.player1);
 
         P1Life = 5;
         for (int i = 0; i < p1Sticks.Length; i++)
         {
             if (P1Life > i)
             {
                 p1Sticks[i].SetActive(true);
             }
             else
             {
                 p1Sticks[i].SetActive(false);
             }
         }
     }
 
     if (P2Life <= 0)
     {
         Destroy(this.player2);
 
         P2Life = 5;
         for (int i = 0; i < p2Sticks.Length; i++)
         {
             if (P2Life > i)
             {
                 p2Sticks[i].SetActive(true);
             }
             else
             {
                 p2Sticks[i].SetActive(false);
             }
         }
     }
 }


Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image HeliumB · May 22, 2018 at 01:53 PM 1
Share

This works perfectly, thanks!

I will check those tutorials out.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

110 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Destroy Prefab clone 2 Answers

Deleting a GameObject 2 Answers

I want to only destroy 3 of the clone prefabs that appear how would I do this? 1 Answer

How to destroy a clone (instantiate in scene) in the their own script 1 Answer

Destroying assets is not permitted to avoid data loss? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges