Check bool from multiple instances of the same script

Question

Hello, I am trying to check if a bool on a script is false if it leaves the collider. The "dropzones" objects all have the tag "dropzone" and the script "DropZone1" is in the scene multiple times, attached once to each of the dropzone objects. In their Start Function, I have written satisfied as false. My boundary script looks like this:

 public class DestroyByBoundary : MonoBehaviour
 {
     GameObject[] dropzones;
     DropZone1 dropzonescript;
     GameController gameController;
 
     private void Start()
     {
         gameController = FindObjectOfType<GameController>();
         dropzones = GameObject.FindGameObjectsWithTag("dropzone");
         foreach (GameObject zones in dropzones)
         {
             DropZone1 dropzonescript = zones.GetComponent<DropZone1>();
         }
     }
     void OnTriggerExit(Collider other)
     {
         
         if (other.gameObject.tag == "dropzone")
         {
             verifyifSatisfied(dropzonescript.satisfied);
         }
         
     }
     void verifyifSatisfied(bool satisfied)
     {
         
             if (dropzonescript.satisfied == false)
             {
                 gameController.NoAnswer();
                 gameController.DecideIfDisplay();
             }
         
     }
 }

I would like to make it so if one of those "dropzones" leaves the collider, it calls that "verifyifsatisfied" function. However, whenever I test, the code has a nullreferenceexception. Is there a way to fix this?

Answer 1

From what I can understand, your`DestroyByBoundary` script should look like this:

 public class DestroyByBoundary : MonoBehaviour {
     GameController gameController;
     
     private void Start () {
         GameController = FindObjectOfType<GameController> ();
     }
     
     void OnTriggerExit (Collider other)  {
         if (other.gameObject.CompareTag ("dropzone")) {    //is better to use ".CompareTag ("YourTag")" then ".tag == "YourTag"
             if (other.getComponent<DropZone1> ()) {
                 verifyifSatisfied (other.getComponent<DropZone1> ().satisfied);
             }
         }
     }
     
     void verifyifSatisfied (bool satisfied) {
         if (!satisfied) {    //"!satisfied" is the same as "satisfied == false"
             gameController.NoAnswer ();
             gameController.DecideIfDisplay ();
         }
     }
 }

And to make it even more polished, you could even summarize it like this:

 public class DestroyByBoundary : MonoBehaviour {
     GameController gameController;
     
     private void Start () {
         GameController = FindObjectOfType<GameController> ();
     }
     
     void OnTriggerExit (Collider other)  {
         if (other.gameObject.CompareTag ("dropzone")) {
             if (other.getComponent<DropZone1> () && other.getComponent<DropZone1> ().satisfied) { {
                 gameController.NoAnswer ();
                 gameController.DecideIfDisplay ();
             }
         }
     }
 }

Let me know if this helps.

Answer 2

Answer by Ady_M · Jan 06 at 02:46 AM

Try something along the lines of this.

I still don't know what the foreach is for, though.

 public class DestroyByBoundary : MonoBehaviour
 {
     GameObject[] dropzones;
     //DropZone1 dropzonescript;  // Ady: Delete this
     GameController gameController;

     private void Start()
     {
         gameController = FindObjectOfType<GameController>();
         dropzones = GameObject.FindGameObjectsWithTag("dropzone");
         foreach (GameObject zones in dropzones)
         {
             // Ady: I have no idea what you were trying to do here
             //DropZone1 dropzonescript = zones.GetComponent<DropZone1>();   // Ady disabled code
         }
     }

     void OnTriggerExit(Collider other)
     {
         if (other.gameObject.tag == "dropzone")
         {
             // Ady: Gets the DropZone1 script that's attached to the object that exited the trigger
             var dropzonescript = other.GetComponent<DropZone1>();  // Ady
             verifyifSatisfied(dropzonescript);  // Ady
         }
     }
     
     void verifyifSatisfied(DropZone1 dropzonescript)  // Ady: Replaced parameter with DropZone1 type
     {
         if (dropzonescript.satisfied == false)
         {
             gameController.NoAnswer();
             gameController.DecideIfDisplay();
         }
     }
 }

Add comment · Show 14 · Share

Frank-1999-98K · Jan 06 at 03:01 AM 1

Share

dcw2001 Frank-1999-98K · Jan 06 at 03:41 AM 1

Share

Ady_M dcw2001 · Jan 06 at 04:17 AM 1

Share

Show more comments

dcw2001 · Jan 06 at 03:51 AM 1

Share

Ady_M dcw2001 · Jan 06 at 04:36 AM 0

Share

Check bool from multiple instances of the same script

2 Replies

Welcome to Unity Answers

Follow this Question

Related Questions