My attached script is not working. Can someone help with my coding?

Question

I'm trying to do two things with the attached script: first to get the slider and text to reflect the health of the player. The health text shows the full amount of health(3) however it does not change with health as indicated by the Debug.Log("Health: " + health). Also, the lines of code under Update are not functioning. I've attached the HealthBar script to an empty gameObject. The slider and the text are also attached and the total health int is also attached in the gameObject named HealthBar.

The second issue is that I am trying to get DontDestroyOnLoad to work. I'm new to Unity and gaming so any help would br really apprceciated.

using System.Collections; using System.Collections.Generic; using UnityEngine; using UnityEngine.UI; using UnityEngine.SceneManagement;

public class Healthbar: MonoBehaviour {

 public int health;
 public Slider slider;
 public Text text;

 /*void Awake()
 {
     GameObject[] objs = GameObject.FindGameObjectsWithTag("Health");

     if (objs.Length > 1)
     {
         Destroy(this.gameObject);
     }

     DontDestroyOnLoad(this.gameObject);
 }*/
 void Update()
 {
     Debug.Log("update");
     slider.value = health; 
     text.text ="Health : " + health;

     /*if(health <= 0)
         {
             Debug.Log("Game Over");
         }*/
 }



 void OnTriggerEnter (Collider other)
 {
     if (gameObject.tag == "Hazards") 
     {    
         
         health = health - 1; 
         Debug.Log ("Health: " + health);
         Destroy (other.gameObject);

         //SceneManager.LoadScene (SceneManager.GetActiveScene ().buildIndex);



     }
 }

}

Answer 1

Answer by Tasarran · Jan 31, 2019 at 04:48 PM

slider.value is a float, not an int. Either change health to be a float or 'cast' it thusly:

 slider.value = (float) health;

You're also going to have a similar problem on the next line; health is an int, you can't add a string and an int. It should be:

 text.text = "Health : " + health.ToString();

Yes, completely different ways of changing one data type into another, this isn't just for example purposes. For simple data types, you can just (type) cast them, but for strings, you need to use int.ToString() (in this case).

Add comment · Show 9 · Share

wmmayfield · Jan 31, 2019 at 04:57 PM 0

Share

Thanks for yoru help. I made the changes as you suggested but it still fails to work. Any thoughts on the DontDestroyOnLoad?

Tasarran · Jan 31, 2019 at 05:41 PM 0

Share

Is your Slider set up with a $$anonymous$$in and $$anonymous$$ax, and is the Whole Numbers setting turned on? If you haven't set that up, your default Slider only goes from 0.0-1.0, I believe...

wmmayfield · Jan 31, 2019 at 05:46 PM 0

Share

slider is set as you suggest and ther is still no movement. It seems like it is detached from the action of the scene. The text loads the slider to health of 3 but as the scene runs the debug.log counts and calls game over correctly. The slider just sits there.

wmmayfield · Jan 31, 2019 at 05:50 PM 0

Share

Tried your suggestion and all that did was to shrink the health bar. Am I missing anything with regards to connecting the slider to the script?

Tasarran · Jan 31, 2019 at 06:01 PM 0

Share

What happens if you change that to

 slider.value = 1;

Show more comments

Answer 2

Answer by Magso · Jan 31, 2019 at 04:56 PM

Firstly where you have Destroy and DontDestroyOnLoad, just use (gameObject). 'this' refers to the script itself so 'Destroy(this)' would remove the script's own component.

Secondly the if statement checking the tag is checking the gameObejcts own tag, not the hazard's tag. You can use

 if (other.tag == "Hazards")
 //or
 if (other.gameObject.tag == "Hazards")

Thirdly, just a nitpick but

 health = health - 1; 
 //can be written as
 health--;

When you plus or minus 1, it's either ++ or -- , if it's not just 1 you can use

 health += 2f;
 //and 
 health -= 4.2635f;

The f at the end stands for float.

Add comment · Show 2 · Share

wmmayfield · Jan 31, 2019 at 05:10 PM 0

Share

Thanks for the suggestions. They are working somewhat. The Debug.Log("Health: " + health) is correctly counting and calling GameOver. However the health bar shows no movement or change in number. It always shows 3.

I'm open to additional thoughts and suggestions.

Magso wmmayfield · Jan 31, 2019 at 05:46 PM 0

Share

Tasarran mentioned the slider's value has to be between 0 and 1 so

 public float health;
 slider.value = health/3;

should work for that, but make sure the health variable is a float, not an integer.

Answer 3

Answer by AnOrdinarySandwich · Feb 01, 2019 at 01:47 AM

Don't worry about changing your health to a float if that's not what you need. The only real issue is making sure the slider's max and min values are set. I'm assuming minimum health is 0, so slider.minValue should be defaulted to 0 ( but it doesn't hurt to assign it anyway). Then, set maxValue to whatever the maximum health is, and after, keep updating the slider.value = health.

For DontDestroyOnLoad, firstly, it must be on a root gameObject (in the hierarchy) or on a component on a root gameObject.

No offense @Tasarran, but int's don't need to be cast to float, they'll auto convert. Additionally, int's and float don't require ToString() to append to a string, they'll auto-convert.

void Start()
{
   int ten=10;
   float d = ten;
   string output = "x = "+ten + " : " + d;
}

This code gives me no errors.

Add comment · Share

My attached script is not working. Can someone help with my coding?

3 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions