• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by jay-macgregor · Feb 22, 2019 at 01:26 AM · c#2dios2d game2d-platformer

Right guys struggling here! new to code... My first object (power up) is being destroyed but no power function is being generated, second object and there after works perfectly. PLEASE HELP

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class PowerUps : MonoBehaviour
 {
     public bool doublePoints;
     public float powerupLength;
     private PowerupManager thePowerupManager;
 
     // Start is called before the first frame update
     void Start()
     {
         thePowerupManager  = FindObjectOfType<PowerupManager>();
     }
 
     void Awake()
     {
         doublePoints = true;
     }
 
     void OnTriggerEnter2D(Collider2D other)
     {
         if(other.name == "Player")
         {
             thePowerupManager.ActivatePowerup(doublePoints, powerupLength);
             gameObject.SetActive(false);
         }
     }
 }
 
 -------------------
 
 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEngine.UI;
 
 public class PowerupManager : MonoBehaviour
 {
     private bool doublePoints;
     public Image dxp;
     private bool powerupActive;
     private float powerupLengthCounter;
     private ScoreManager theScoreManager;
     private PlatformGenerator thePlatformGenerator;
     private GameManager theGameManager;
     private float normalPointsPerSecond;
 
     // Start is called before the first frame update
     void Start()
     {
         theScoreManager = FindObjectOfType<ScoreManager>();
         thePlatformGenerator = FindObjectOfType<PlatformGenerator>();
         theGameManager = FindObjectOfType<GameManager>();
         dxp.enabled = false;
     }
 
     // Update is called once per frame
     void Update()
     {
         if(powerupActive)
         {
             powerupLengthCounter -= Time.deltaTime;
             dxp.enabled = true;
 
             if(theGameManager.powerupReset)
             {
                 powerupLengthCounter = 0;
                 theGameManager.powerupReset = false;
             }
 
             if(doublePoints)
             {
             theScoreManager.pointsPerSecond = normalPointsPerSecond * 2;
             theScoreManager.shouldDouble = true;
             }
 
             if(powerupLengthCounter <= 0)
             {
             theScoreManager.pointsPerSecond = normalPointsPerSecond;
             theScoreManager.shouldDouble = false;
             powerupActive = false;
             }
         }
 
         if(!powerupActive)
             {
                 dxp.enabled = false;
             }
 
      }
 
     public void ActivatePowerup(bool points, float time)
     {
         doublePoints = points; 
         powerupLengthCounter = time;
         
         if(!powerupActive)
         {
             normalPointsPerSecond = theScoreManager.pointsPerSecond;
         }
         powerupActive = true;
     }
 }

Comment
Add comment · Show 3
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Shine_Bolt · Feb 22, 2019 at 11:37 PM 0
Share

You sure have a lot of boolean variables. Do you really need doublePoints? Can you not just use dxp.enabled, or theScore$$anonymous$$anager.shouldDouble?

$$anonymous$$ore importantly when is ActivatePowerup being called and how?

Finally, your indentation is inconsistent try this:

 public class Powerup$$anonymous$$anager : $$anonymous$$onoBehaviour
 {
     private bool doublePoints;
     public Image dxp;
     private bool powerupActive;
     private float powerupLengthCounter;
     private Score$$anonymous$$anager theScore$$anonymous$$anager;
     private PlatformGenerator thePlatformGenerator;
     private Game$$anonymous$$anager theGame$$anonymous$$anager;
     private float normalPointsPerSecond;
      
     // Start is called before the first frame update
     void Start()
     {
         theScore$$anonymous$$anager = FindObjectOfType<Score$$anonymous$$anager>();
         thePlatformGenerator = FindObjectOfType<PlatformGenerator>();
         theGame$$anonymous$$anager = FindObjectOfType<Game$$anonymous$$anager>();
         dxp.enabled = false;
     }
      
     // Update is called once per frame
     void Update()
     {
         if(powerupActive)
         {
             powerupLengthCounter -= Time.deltaTime;
             dxp.enabled = true;
              
             if(theGame$$anonymous$$anager.powerupReset)
             {
                 powerupLengthCounter = 0;
                 theGame$$anonymous$$anager.powerupReset = false;
             }
              
             if(doublePoints)
             {
                 theScore$$anonymous$$anager.pointsPerSecond = normalPointsPerSecond * 2;
                 theScore$$anonymous$$anager.shouldDouble = true;
             }
              
             if(powerupLengthCounter <= 0)
             {
                 theScore$$anonymous$$anager.pointsPerSecond = normalPointsPerSecond;
                 theScore$$anonymous$$anager.shouldDouble = false;
                 powerupActive = false;
             }
         }
          
         if(!powerupActive) dxp.enabled = false;
      
     }
      
     public void ActivatePowerup(bool points, float time)
     {
         doublePoints = points; 
         powerupLengthCounter = time;
 
         if(!powerupActive) normalPointsPerSecond = theScore$$anonymous$$anager.pointsPerSecond;
         powerupActive = true;
     }
 }
avatar image jay-macgregor Shine_Bolt · Feb 26, 2019 at 05:32 PM 0
Share

Hello ShineBolt, Thankyou for your reply and i have now replaced my code with yours and works fine. The error was actually a public boolean that i had set to active when should of been false by mistake, took me a while to figure it out :)

avatar image Shine_Bolt jay-macgregor · Feb 26, 2019 at 11:34 PM 0
Share

Oh, your welcome, but just fyi the indentation doesn't effect how the program runs at all. In fact most spacing doesn't change anything, it's just for readability. $$anonymous$$ost people indent the code of any block that isn't on one line, and will look to the indentation to find whether or not a line of code is part of a block, not the brackets.

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

658 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Teleport 2D Character on TriggerEnter 2 Answers

CS1216 error 0 Answers

Coyote Timer Gives Double Jump Frames. 1 Answer

Trouble with directing launched projectiles in Unity 2D 0 Answers

Trouble with controlling the direction of projectiles with C# code 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges