When more than 1 enemy they cant die

Question

So I'm trying to make an enemy but when there are 2 enemies when the first one dies the second one just go in minus in health and I just can't seem to fix it can anyone help me?

 using System.Collections.Generic;
 using UnityEngine;
 using TMPro;
 using System.Collections;
 
 public class StoneGolemController : MonoBehaviour
 {
     #region Variable Declarations
 
     GameObject Player;
 
     public List<GameObject> Targets;
     public GameObject Orb;
 
     public TextMeshProUGUI displayText;
 
     public float MoveSpeed = 2f;
 
     float searchRadius = 100f;
     float meleeRadius = 2f;
     float throwRadius = 5f;
     public float maxThrowingStones = 30f;
     public float currentThrowingStones;
     public Transform ThrowingStone;
 
     float currentTargetDistance;
 
     public static StoneGolemController instance;
     public float MaxHealth = 500;
     public float CurrentHealth;
     public static int DeathHealth = 0;
 
     public GameObject StoneGolem;
 
     public bool onCooldown = false;
     public float delay = 3f;
 
     GameObject myTarget;
     #endregion
 
     void Awake()
     {
         Player = GameObject.FindGameObjectWithTag("Player");
         Orb = GameObject.FindGameObjectWithTag("Orb");
         StoneGolem = GameObject.FindGameObjectWithTag("StoneGolem");
         instance = t$$anonymous$$s;
         CurrentHealth = MaxHealth;
 
         Targets = new List<GameObject>(GameObject.FindGameObjectsWithTag("Building"))
         {
            Orb
         };
 
         //ThrowingStone.transform.position = StoneGolem.transform.position;
 
         currentThrowingStones = maxThrowingStones;
     }
 
     void Update()
     {
         {
             TargetFinder();
 
             if (myTarget == null)
                 currentTargetDistance = searchRadius;
             else
                 Move(myTarget.transform);
             {
                 if (currentThrowingStones > 0)
                 {
                     if (currentTargetDistance <= throwRadius && !onCooldown)
                     {
                         StartCoroutine(ThrowDelayLogic());
                         MoveSpeed = 0f;
                     }
                 }
                 if (currentThrowingStones > 0)
                 {
                     if (currentTargetDistance >= throwRadius && !onCooldown)
                     {
                         MoveSpeed = 2f;
                     }
                 }
                 if (currentThrowingStones <= 0)
                 {
                     MoveSpeed = 2f;
                     if (currentTargetDistance <= meleeRadius)
                     {
                         DoMelee();
                     }
                 }
             }
 
             if (CurrentHealth <= DeathHealth)
             {
                 print("Enemy Has died!!!");
                 Destroy(StoneGolem);
             }
         }
 
         void TargetFinder()
         {
             foreach (var x in Targets)
             {
                 float distance = (transform.position - x.transform.position).magnitude;
 
                 if (distance < currentTargetDistance)
                 {
                     myTarget = x;
                     //displayText.text = "My target: " + x + "\n Distance to Target: " + distance; //skal fjernes nå det er helt klart
                     currentTargetDistance = distance;
                 }
             }
         }
 
         void Move(Transform t)
         {
             transform.LookAt(t);
             transform.position += transform.forward * MoveSpeed * Time.deltaTime;
         }
 
         void DoMelee()
         {
             //if ($$anonymous$$t.collider.tag == "Player")
             {
                 //PlayerController eHealth = $$anonymous$$t.collider.GetComponent<PlayerController>();
                 //PlayerController.instance.CurrentHealth -= Random.Range(minWeaponDamage, maxWeaponDamage + 1);
                 //print("Player took some damage");
             }
             myTarget = null;
             currentTargetDistance = searchRadius;
         }
 
         void DoThrow()
         { 
             myTarget = null;
             currentTargetDistance = searchRadius;
             Instantiate(ThrowingStone);
             currentThrowingStones--;
         }
 
         IEnumerator ThrowDelayLogic()
         {
             DoThrow();
             onCooldown = true;
             yield return new WaitForSeconds(delay);
             onCooldown = false;
         }
     }
 }

Answer 1

Answer by sacredgeometry · Aug 09, 2019 at 07:33 PM

The problem is probably:

 public static StoneGolemController instance;

The static modifier means that its a class member not an instance member. So there is only ever one of them. Assuming that you are creating a bunch of these it will be the last one you created. If you are referencing it elsewhere then you will always be referencing that last StoneGolemController.

See: StaticMember Documentation

Add comment · Show 5 · Share

nicoolsen10 · Aug 09, 2019 at 07:38 PM 0

Share

But if i remove it this wont work how do you wanna fix it?

    private void DoAttack()
     {
 
         Ray ray = PlayingCam.ScreenPointToRay(Input.mousePosition);
         RaycastHit hit;
 
         if (Physics.Raycast(ray, out hit, myWeapon.attackRange))
         {
             if (hit.collider.tag == "StoneGolem")
             {
                 StoneGolemController eHealth = hit.collider.GetComponent<StoneGolemController>();
                 StoneGolemController.instance.CurrentHealth -= Random.Range(minWeaponDamage, maxWeaponDamage + 1);
                 print("Enemy took some damage");
             }
         }
     }

sacredgeometry nicoolsen10 · Aug 09, 2019 at 07:46 PM 0

Share

It doesn't work because your code is not correct.

So you need to choose a method for referencing your object. If you are using RayCasting you can get the GameObject/ Component from the Collider that gets hit.

Let me mock up an example for you

sacredgeometry nicoolsen10 · Aug 09, 2019 at 07:56 PM 0

Share

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class Player : MonoBehaviour
 {
     void Update ()
     {
         if(Input.GetKeyDown(KeyCode.Space)) 
         {
             DoAttack();
         }
     }
 
     private void DoAttack()
      {
          Ray ray = Camera.main.ScreenPointToRay(Input.mousePosition);
          RaycastHit hit;
  
          if (Physics.Raycast(ray, out hit, Mathf.Infinity))
          {
              if (hit.collider.tag == "Enemy")
              {
                 var enemy = hit.collider.GetComponent<EnemyScript>();
                 enemy.Health -= 25;
 
                 print($"Enemy took some damage. Health = {enemy.Health}");
              }
          }
      }
 }
  
 public class EnemyScript : MonoBehaviour
 {
     public double Health = 100;
 }

sacredgeometry nicoolsen10 · Aug 09, 2019 at 07:56 PM 0

Share

Is the example clear enough or do you need me to make a video explaining it?

Edit: There. thats as little code as you need.

nicoolsen10 sacredgeometry · Aug 09, 2019 at 08:03 PM 0

Share

It could be nice if you could make a video cause i cant get it to work

When more than 1 enemy they cant die

1 Reply

The problem is probably:

See: StaticMember Documentation

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions