Object keeps moving up even when StopCoroutine is called

Question

Hello guys, I'm trying to move an object in the "up" direction whenever the player enters a collider using OnTriggerStay. I used the code below w$$anonymous$$ch includes a Coroutine.

 if (other.gameObject.tag == "Puzzle2") // fence2 closes on puzzle2 smoothly
         {
             StartCoroutine("Fence2Up");
         }
     }
 
     IEnumerator Fence2Up()
     {
         fence2.transform.Translate(Vector3.up * Time.deltaTime * 3);
         new WaitForSeconds(6f);
         print("It should stop!");
         StopCoroutine("Fence2Up");
         yield return null;
     }

The if statement is in the "OnTriggerStay " function. Basically, the object correctly moving upward whenever I enter the collider. Yet, It doesn't stop after 6 seconds w$$anonymous$$ch I specified in the IEnumerator function where I mentioned StopCoroutine. Also, the print function works properly after 6 seconds.

Answer 1

Best Answer

Answer by Anis1808 · Dec 03, 2019 at 02:25 AM

It seems like you are still staying in the trigger so you should only call the coroutine once. So just create a boolean named startedCoroutine and it should work.

 if (other.gameObject.tag == "Puzzle2" && !startedCoroutine) 
          {
              StartCoroutine("Fence2Up");
              startedCoroutine = true;
          }
      }

EDIT

Another problem with the code is that new WaitForSeconds(6f); does not do much, you have to call yeild return new WaitForSeconds(6); for it to actually wait 6 seconds.

What I suggest is that you don't use a coroutine at all and use Update instead, like t$$anonymous$$s

 float timeLeft = 6f;
 bool runCode;
 
 void Update(){
           if(runCode){
                    timeLeft -= Time.deltaTime;
                    if(timeLeft>0){
                              fence2.transform.Translate(Vector3.up * Time.deltaTime * 3);
                    }
           }
 }
 
 void OnTriggerStay(Collider other){
           if (other.gameObject.tag == "Puzzle2" && !runCode) 
           {
               runCode= true;
           }
 }

1 Show 3 · Share

hballamco · Dec 03, 2019 at 02:32 AM 0

Share

Thanks for the reply, I tried what you said but unfortunately I didn't get the result needed. What happens is that the object didn't move at all. Plus, the print function showed up immediately ignoring the 6 seconds condition that I specified.

Anis1808 · Dec 03, 2019 at 03:15 AM 0

Share

Updated my code, it should work better now.

hballamco · Dec 04, 2019 at 03:45 AM 0

Share

@Anis1808 Indeed, I don't need to use Coroutine function. I got what I want. Thanks to you and I appreciate your effort and time.

Answer 2

Your usage of the coroutine is all wrong.

Coroutine should contain a conditional loop (`w$$anonymous$$le`) or conditional statement (`if`), and the code that should be executed continuously must be placed inside t$$anonymous$$s loop/statement scope.
The scope then should end up with one of the yield return instructions determining when the next iteration should be executed again. Note that the yield return should be inside the loop/statement scope.

Once the condition return false, the coroutine is over, and the execution order will go to outside of the condition scope.

So, if you want to continuously move the transform up for 6 seconds (I t$$anonymous$$nk that's what you're trying to do), you should call the coroutine t$$anonymous$$s way:

 IEnumerator Fence2Up()
 {
     // the counter will be substructed with Time.deltaTime after every coroutine iteration
     // and we'll execute next coroutine step every frame using yield return null
     float counter = 6f;
     // set up the condition that will determine if the coroutine should be executed again or not
     w$$anonymous$$le (counter > 0)
     {
         print("Coroutine is running, counter=" + counter);
         fence2.transform.Translate(Vector3.up * Time.deltaTime * 3);
         counter -= Time.deltaTime;
         print("Gonna wait for next frame to continue");
         yield return null;
         // here the coroutine will be paused untill the next frame
         // and in the next frame it will execute the code inside the w$$anonymous$$le scope again if the counter will still be more than 0
         // if you use WaitForSeconds here instead of yield return null,
         // the coroutine will be paused for 6 seconds and it will move the transform and substruct counter only every 6 secods
     }
     // if the counter is 0, then the coroutine will stop itself
      print("The coroutine has stopped because the counter is 0 or less. Counter=" + counter);
      // no need to stop the coroutine, it already has stopped itself
  }

And don't use OnTriggerStay() since you use a coroutine here. Because it just doesn't make sense. Coroutines are designed to be called just once and once you've called the coroutine, it will call itself automatically if the condition inside the coroutine is true. That's what coroutines are made for.

So, if you want to move the fence for 6 seconds whenever player gets into the trigger area, use OnTriggerEnter() w$$anonymous$$ch is called just once, and you won't have to stop and restart the coroutine manually. You call the coroutine once and it recalls itself automatically w$$anonymous$$le the condition is true and then stops itself.

Object keeps moving up even when StopCoroutine is called

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions