• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by JustARoom · Dec 08, 2019 at 11:05 AM · c#simplifyshort

Best way to make this code shorter?

I'm working on dungeon generation and i ended up with a long code, I would like to shorten it if possible, but i'm a big noob, anyone got any ideas?

 if (roomScript.rCheck[0].room != null) {
             if (roomScript.connectionsAvailable[0] == true || roomScript.rCheck[0].connectionsAvailable[2] == true) {
                 roomScript.roomConnections[0].SetActive(false);
                 roomScript.connectionsEnabled[0] = true;
                 roomScript.connectionsConnected[0] = true;
                 roomScript.connectionsAvailable[0] = false;
 
                 roomScript.rCheck[0].roomScript.roomConnections[2].SetActive(false);
                 roomScript.rCheck[0].roomScript.connectionsEnabled[2] = true;
                 roomScript.rCheck[0].roomScript.connectionsConnected[2] = true;
                 roomScript.rCheck[0].roomScript.connectionsAvailable[2] = false;
             }
         }
 
         if (roomScript.rCheck[1].room != null) {
             if (roomScript.connectionsAvailable[1] == true || roomScript.rCheck[1].connectionsAvailable[3] == true) {
                 roomScript.roomConnections[1].SetActive(false);
                 roomScript.connectionsEnabled[1] = true;
                 roomScript.connectionsConnected[1] = true;
                 roomScript.connectionsAvailable[1] = false;
 
                 roomScript.rCheck[1].roomScript.roomConnections[3].SetActive(false);
                 roomScript.rCheck[1].roomScript.connectionsEnabled[3] = true;
                 roomScript.rCheck[1].roomScript.connectionsConnected[3] = true;
                 roomScript.rCheck[1].roomScript.connectionsAvailable[3] = false;
             }
         }
 
         if (roomScript.rCheck[2].room != null) {
             if (roomScript.connectionsAvailable[2] == true || roomScript.rCheck[2].connectionsAvailable[0] == true) {
                 roomScript.roomConnections[2].SetActive(false);
                 roomScript.connectionsEnabled[2] = true;
                 roomScript.connectionsConnected[2] = true;
                 roomScript.connectionsAvailable[2] = false;
 
                 roomScript.rCheck[2].roomScript.roomConnections[0].SetActive(false);
                 roomScript.rCheck[2].roomScript.connectionsEnabled[0] = true;
                 roomScript.rCheck[2].roomScript.connectionsConnected[0] = true;
                 roomScript.rCheck[2].roomScript.connectionsAvailable[0] = false;
             }
         }
 
         if (roomScript.rCheck[3].room != null) {
             if (roomScript.connectionsAvailable[3] == true || roomScript.rCheck[3].connectionsAvailable[1] == true) {
                 roomScript.roomConnections[3].SetActive(false);
                 roomScript.connectionsEnabled[3] = true;
                 roomScript.connectionsConnected[3] = true;
                 roomScript.connectionsAvailable[3] = false;
 
                 roomScript.rCheck[3].roomScript.roomConnections[1].SetActive(false);
                 roomScript.rCheck[3].roomScript.connectionsEnabled[1] = true;
                 roomScript.rCheck[3].roomScript.connectionsConnected[1] = true;
                 roomScript.rCheck[3].roomScript.connectionsAvailable[1] = false;
             }
         }
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Lazdude17 · Dec 08, 2019 at 07:07 PM 0
Share

you would have to explain what you're trying to accomplish with this code, what's its job? Also, don't give code pieces. Show the whole script or it's likely to just confuse anybody who would help.

2 Replies

· Add your reply
  • Sort: 
avatar image
2

Answer by noamro · Dec 08, 2019 at 07:24 PM

Use a for loop :) instead of using a number use an integer

 for (int i = 0; i < roomScript.connectionsAvailable[].length; i++) 
 {
     roomScript.roomConnections[i].SetActive(false);
 }

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Cornelis-de-Jager · Dec 08, 2019 at 11:17 PM 1
Share

Or even

 foreach (var rs in roomScript.connectionsAvailable){
      rs.SetActive(false);
 }
avatar image
1

Answer by Bunny83 · Dec 08, 2019 at 11:34 PM

Specifically a for loop like this:

 for (int i = 0; i < 4; i++)
 {
     int i2 = (2+i) % 4;
     var rCheck = roomScript.rCheck[i];
     if (rCheck.room != null)
     {
         if (roomScript.connectionsAvailable[i] || rCheck.connectionsAvailable[i2])
         {
             roomScript.roomConnections[i].SetActive(false);
             roomScript.connectionsEnabled[i] = true;
             roomScript.connectionsConnected[i] = true;
             roomScript.connectionsAvailable[0] = false;
             
             rCheck.roomScript.roomConnections[i2].SetActive(false);
             rCheck.roomScript.connectionsEnabled[i2] = true;
             rCheck.roomScript.connectionsConnected[i2] = true;
             rCheck.roomScript.connectionsAvailable[i2] = false;
         }
     }
 }

This does the same as your current code.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Bunny83 · Dec 08, 2019 at 11:38 PM 0
Share

Note that "i2" is always 2 ahead of "i" but wraps around back to 0 when it reaches 4

 //i  | i2
 //-------
 //0  |  2
 //1  |  3
 //2  |  0
 //3  |  1

Since roomScript.rCheck[i] was used several times in your code I stored it in the local variable rCheck to simplify the lines where it was used.

avatar image Bunny83 · Dec 08, 2019 at 11:44 PM 2
Share

ps: If you really want to simplify your code you should use less individual arrays which logically belong together. If you have data that belongs together you might want to create a pure data class and group data together that belongs together. Your "roomConnection" seems to be an array of GameObjects. The other arrays (connectionsEnabled, connectionsConnected, connectionsAvailable) seems to belong to each connection so those 4 values should be grouped and then you would only have a single array and one instance of your data class for each connection. However to me most of these values (just based on the names and how you use them here) seems redundant anyways. Though we can't really suggest other approaches without knowing the exact usage and dependencies.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

682 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Distribute terrain in zones 3 Answers

Initialising List array for use in a custom Editor 1 Answer

Illuminating a 3D object's edges OnMouseOver (script in c#)? 1 Answer

Flip over an object (smooth transition) 3 Answers

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges