• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
1
Question by FredTuna · Jan 11, 2020 at 05:53 PM · prefabprefabutility

Modify Prefab Asset in OnValidate

Hi, I'm trying to automatically assign a value to a field on a component that resides in a prefab in script and save that prefab modification in OnValidate.

Here is my script:

  [SerializeField] MyComponent myComponent;
  void OnValidate()
  {
      if (myComponent != null)
      {
          myComponent.myScriptableObject = this;
          PrefabUtility.RecordPrefabInstancePropertyModifications(myComponent.myScriptableObject); 
 //At this point, myComponent.myScriptableObject shows the correct value
          PrefabUtility.SavePrefabAsset(myComponent.gameObject, out bool success);
 //Now myComponent.myScriptableObject is reset to null
      }
  }


Unfortunately, this script doesn't work. For some reason the value is not actually applied to the prefab. What am I missing here?

Also, calling SavePrefabAsset() in Onvalidate gives me the following error in console :

 Destroying GameObjects immediately is not permitted during physics trigger/contact, animation event callbacks or OnValidate. You must use Destroy instead.
 UnityEditor.PrefabUtility:SavePrefabAsset(GameObject, Boolean&) (at ?)
 ResearchTree.Data.ResearchItem:OnValidate() 


Is this related in any way?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
1

Answer by FredTuna · Jan 15, 2020 at 09:30 PM

In case others were looking for that answer. This is what I ended up doing:

 SerializedObject serializedObject = new SerializedObject(myComponent);
 SerializedProperty myComponentProperty = serializedObject.FindProperty("myProperty");
     
 if (myComponentProperty != null)
 {
         myComponentProperty.objectReferenceValue = this;
         serializedObject.ApplyModifiedProperties();
 }

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by Esteem · Jan 16, 2020 at 09:18 PM

What are you actualy trying to do? There's something fishy about what you showed ...

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image FredTuna · Jan 17, 2020 at 12:05 AM 0
Share

I'm just trying to set a serialized field of a component on a prefab to a certain value from a scriptable object's OnValidate.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

153 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Why is PrefabUtility.IsPartOfAnyPrefab(gameObject) returning false even though the object is a prefab? 1 Answer

cannot load GameObject Prefabs using Resources.Load in Android 0 Answers

Can I create a child gameobject on a prefab with an editor script 1 Answer

How can I destroy a gameobject that is part of a prefab ? 0 Answers

Does my script have a memory leak ? 0 Answers

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges