• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by TheNinjamaster · May 04, 2020 at 02:42 AM · shader writing

I'm trying to make a shader with both a rim light and shadows.

I'm trying to make a shader with both a rim light and shadows. However, I've only gotten the rim light as nothing I've found on the web has given correct shadows. All that has happened is that the shader broke. Here is the code I have so far.

  Shader "Custom/Rim Light"
     {
         Properties{
             _Color ("Main Color", Color) = (1,1,1,1)
             _RimColor ("Rim Color", Color) = (1,1,1,1)
             _MainTex("Base (RGB)", 2D) = "white" {}
         }
     
         SubShader{
             
             Pass{
                 CGPROGRAM
     
                 #pragma vertex vert
                 #pragma fragment frag
                 #include "UnityCG.cginc"
                 struct appdata {
                     float4 vertex : POSITION;
                     float3 normal : NORMAL;
                     float2 texcoord : TEXCOORD0;
                 };
                 struct v2f {
                     float4 pos : SV_POSITION;
                     float2 uv : TEXCOORD0;
                     float3 color : COLOR;
                 };
                 uniform float4 _MainTex_ST;
                 uniform float4 _RimColor;
     
                 v2f vert(appdata_base v) {
                     v2f o;
                     o.pos = UnityObjectToClipPos (v.vertex);
     
                     float3 viewDir = normalize(ObjSpaceViewDir(v.vertex));
                     float dotProduct = 1 - dot(v.normal, viewDir);
                     float rimWidth = 0.7;
                     o.color = smoothstep(1 - rimWidth, 1.0, dotProduct);
     
                     o.color *= _RimColor;
     
                     o.uv = TRANSFORM_TEX(v.texcoord, _MainTex);
                     
                     return o;
                 }
                 uniform sampler2D _MainTex;
                 uniform float4 _Color;
                 
                 float4 frag(v2f i) : COLOR{
                     float4 texcol = tex2D(_MainTex, i.uv);
                     texcol *= _Color;
                     texcol.rgb += i.color;
                     return texcol;
                 }
                 ENDCG
             }
         }
     }
     
 
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Namey5 · May 04, 2020 at 12:57 PM

You would be much better off using a surface shader for this kind of thing - and conveniently enough, the third example for writing surface shaders in the manual is exactly this.

https://docs.unity3d.com/Manual/SL-SurfaceShaderExamples.html

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image TheNinjamaster · May 04, 2020 at 02:38 PM 0
Share

thank you!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

127 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Geometry Shader misses vertices problem. 2 Answers

Multiple instances of one shader, and merging shaders on model? 0 Answers

Set PSIZE in Surface shader 0 Answers

Question on Shader Function Return Values,Question on shader function return values 1 Answer

Depth mask with alpha / adding alpha to frag grabpass shader 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges