• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by DH00 · May 29, 2020 at 11:12 AM · c#nullreferenceexceptionlistsforeachdestroygameobject

Unable to delete object from a list using foreach loop

I have been unable to delete the spike Gameobject. It always throws a null reference exception error. I can't seem to figure out the issue here.
Check KillOldSpikes() the last function in the code.

(Line 225)

Code:

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEngine.UI;
 
 public class GameController : MonoBehaviour
 {
     public static GameController instance = null;
 
     const float width = 3.7f;
     const float height = 7f;
 
     public float snakeSpeed = 1;
 
     public BodyPart bodyPrefab = null;
     public GameObject rockPrefab = null;
     public GameObject eggPrefab = null;
     public GameObject goldEggPrefab = null;
     public GameObject spikePrefab = null;
 
     public Sprite tailSprite = null;
     public Sprite bodySprite = null;
 
     public SnakeHead snakeHead = null;
 
     public bool alive = true;
 
     public bool waitingToPlay = true;
 
     List<Egg> eggs = new List<Egg>();
     List<Egg> spikes = new List<Egg>();
 
     int level = 0;
     int noOfEggsForNextLevel = 0;
 
     public int score = 0;
     public int $$anonymous$$Score = 0;
 
     public Text scoreText = null;
     public Text $$anonymous$$ScoreText = null;
 
     public Text tapToPlayText = null;
     public Text gameOverText = null;
 
     // Start is called before the first frame update
     void Start()
     {
         instance = t$$anonymous$$s;
         Debug.Log("Starting Snake Game");
         CreateWalls();
         alive = false;
     }
 
     // Update is called once per frame
     void Update()
     {
         if (waitingToPlay)
         {
             foreach (Touch touch in Input.touches)
             {
                 if (touch.phase == TouchPhase.Ended)
                 {
                     StartGamePlay();
                 }
             }
 
             if (Input.GetMouseButtonUp(0))
                 StartGamePlay();
         }
     }
 
     public void GameOver()
     {
         alive = false;
         waitingToPlay = true;
 
         gameOverText.gameObject.SetActive(true);
         tapToPlayText.gameObject.SetActive(true);
     }
 
     void StartGamePlay()
     {
         score = 0;
         level = 0;
 
         scoreText.text = "Score = " + score;
         $$anonymous$$ScoreText.text = "HiScore = " + $$anonymous$$Score;
 
         gameOverText.gameObject.SetActive(false);
         tapToPlayText.gameObject.SetActive(false);
 
         waitingToPlay = false;
         alive = true;
 
         KillOldEggs();
         KillOldSpikes();
 
         LevelUp();
     }
 
     void LevelUp()
     {
         level++;
 
         noOfEggsForNextLevel = 4 + (level * 2);
 
         snakeSpeed = 1f + (level / 4f);
         if (snakeSpeed > 6) snakeSpeed = 6;
 
         snakeHead.ResetSnake();
         CreateEgg();
 
         //KillOldSpikes();
         CreateSpike();
 
     }
 
     public void EggEaten(Egg egg)
     {
         score++;
 
         noOfEggsForNextLevel--;
         if (noOfEggsForNextLevel == 0)
         {
             score += 10;
             LevelUp();
         }
         else if (noOfEggsForNextLevel == 1) // last egg
             CreateEgg(true);
         else
             CreateEgg(false);
 
         if (score > $$anonymous$$Score)
         {
             $$anonymous$$Score = score;
             $$anonymous$$ScoreText.text = "HiScore = " + $$anonymous$$Score;
         }
 
         scoreText.text = "Score = " + score;
 
         eggs.Remove(egg);
         Destroy(egg.gameObject);
     }
 
     void CreateWalls()
     {
         float z = -1f;
 
         Vector3 start = new Vector3(-width, -height, z);
         Vector3 finish = new Vector3(-width, +height, z);
         CreateWall(start, finish);
 
         start = new Vector3(+width, -height, z);
         finish = new Vector3(+width, +height, z);
         CreateWall(start, finish);
 
         start = new Vector3(-width, -height, z);
         finish = new Vector3(+width, -height, z);
         CreateWall(start, finish);
 
         start = new Vector3(-width, +height, z);
         finish = new Vector3(+width, +height, z);
         CreateWall(start, finish);
     }
 
     void CreateWall(Vector3 start, Vector3 finish)
     {
         float distance = Vector3.Distance(start, finish);
         int noOfRocks = (int)(distance * 3f);
         Vector3 delta = (finish - start) / noOfRocks;
 
         Vector3 position = start;
         for (int rock = 0; rock <= noOfRocks; rock++)
         {
             float rotation = Random.Range(0, 360f);
             float scale = Random.Range(1.5f, 2f);
             CreateRock(position, scale, rotation);
             position = position + delta;
         }
     }
 
     void CreateRock(Vector3 position, float scale, float rotation)
     {
         GameObject rock = Instantiate(rockPrefab, position, Quaternion.Euler(0, 0, rotation));
         rock.transform.localScale = new Vector3(scale, scale, 1);
     }
 
     void CreateEgg(bool golden = false)
     {
         Vector3 position;
         position.x = -width + Random.Range(1f, (width * 2) - 2f);
         position.y = -height + Random.Range(1f, (height * 2) - 2f);
         position.z = -1f;
         Egg egg = null;
         if (golden)
             egg = Instantiate(goldEggPrefab, position, Quaternion.identity).GetComponent<Egg>();
         else
             egg = Instantiate(eggPrefab, position, Quaternion.identity).GetComponent<Egg>();
 
         eggs.Add(egg);
     }
 
 
     void CreateSpike()
     {
         Vector3 position;
         position.x = -width + Random.Range(1f, (width * 2) - 2f);
         position.y = -height + Random.Range(1f, (height * 2) - 2f);
         position.z = -1f;
         Egg spike = null;
 
         spike = Instantiate(spikePrefab, position, Quaternion.identity).GetComponent<Egg>();
 
         spikes.Add(spike);
     }
 
     void KillOldEggs()
     {
         foreach (Egg egg in eggs)
         {
             Destroy(egg.gameObject);
         }
         eggs.Clear();
     }
 
     void KillOldSpikes()
     {
         foreach (Egg spike in spikes)
         {
             Destroy(spike.gameObject);
 
         }
         spikes.Clear();
     }
 
 }





Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
3
Best Answer

Answer by SteenPetersen · May 29, 2020 at 11:27 AM

You cannot delete t$$anonymous$$ngs using a foreach because when using a foreach in C# you are actually only looking at a copy of the object no the object itself. Your best bet is to use a for loop where you are actually able to delete.

I would follow somet$$anonymous$$ng like t$$anonymous$$s.

How to remove elements from a generic list w$$anonymous$$le iterating over it?

Comment
Add comment · Show 6 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image DH00 · May 29, 2020 at 06:20 PM 0
Share
avatar image KoenigX3 DH00 · May 29, 2020 at 06:29 PM 2
Share
avatar image DH00 KoenigX3 · May 29, 2020 at 07:19 PM 0
Share
avatar image SteenPetersen DH00 · May 29, 2020 at 06:40 PM 0
Share
avatar image DH00 SteenPetersen · May 29, 2020 at 07:20 PM 0
Share
Show more comments

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

733 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Getting NullReferenceException when creating class instance using List 1 Answer

C# - foreach problem 3 Answers

List Elements Double With Replicate Data 0 Answers

null reference exception when I already checked if this was null 1 Answer

Does a new instance of a custom class return null? 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges