• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by DaUr3 · Jul 24, 2020 at 01:42 PM · shadershader programmingcg

Objects Go Into Shadow as Soon as They are Outside of a Point Light's Range

I have recently been trying to program a simple diffuse shader that supports multiple point lights. It works for the most part, but I have encountered this weird effect where the objects lit by the point light won't dim and fade like they do when using the standard surface shader. Instead, as soon as they are outside of the radius of the point light, they go from being lit to being in shadow. There is nothing in between. Just light, or shadow.

I have programmed light attenuation in; however, I am still not sure why this is happening.

SHADER CODE:

 SubShader
 {
     Tags { ... }

     Pass
     {
         Tags {"LightMode" = "ForwardAdd"}

         Blend One One
         CGPROGRAM
         #pragma vertex vert
         #pragma fragment frag

         #include "UnityCG.cginc"
         #include "Lighting.cginc"
         #include "AutoLight.cginc"

         #define POINT

         struct v2f
         {
             float4 pos : SV_POSITION;
             float3 worldPos : TEXCOORD0;
             float3 normal : TEXCOORD1;
         };

         v2f vert (appdata_full v)
         {
             v2f o;
             o.pos = UnityObjectToClipPos(v.vertex);
             o.worldPos = mul(unity_ObjectToWorld, v.vertex);
             o.normal = UnityObjectToWorldNormal(v.vertex);
             return o;
         }

         fixed4 frag (v2f i) : SV_Target
         {                                       
             return float4(0,0,0,1);
         }
         ENDCG
     }

     Pass
     {
         Tags {"LightMode" = "ForwardAdd"}

         Blend One One
         CGPROGRAM
         #pragma vertex vert
         #pragma fragment frag

         #include "UnityCG.cginc"
         #include "Lighting.cginc"
         #include "AutoLight.cginc"

         #define POINT
         struct v2f
         {
             float4 pos : SV_POSITION;
             float3 worldPos : TEXCOORD0;
             float3 normal : TEXCOORD1;
         };

         v2f vert (appdata_full v)
         {
             v2f o;
             o.pos = UnityObjectToClipPos(v.vertex);
             o.worldPos = mul(unity_ObjectToWorld, v.vertex);
             o.normal = UnityObjectToWorldNormal(v.vertex);
             return o;
         }

         fixed4 frag (v2f i) : SV_Target
         {
                       
             float3 lightDir = _WorldSpaceLightPos0.w == 0 ? _WorldSpaceLightPos0.xyz : normalize(_WorldSpaceLightPos0 - i.worldPos);
             float ndotl = saturate(dot(lightDir, i.normal));
             UNITY_LIGHT_ATTENUATION(attenuation, 0, i.worldPos);
             
             fixed4 color = ndotl * attenuation * _LightColor0;
             return color;
         }
         ENDCG
     }
 }

} `

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by DaUr3 · Jul 25, 2020 at 10:29 AM

I looked at some of Unity's other built-in shaders and it seems like this effect was mainly caused by the fact that my shader is not vertex lit. This becomes apparent once you The Standard Shader seems to compute lighting per-vertex and apply a custom light falloff method in order to calculate the fadeaway.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

202 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Can I see the calculation of unity_MatrixVP ? 1 Answer

UnityObjectToClipPos is inverted? 0 Answers

Flat Shading / No Vertex Interpolation 2 Answers

how to approach instanceID in shader? 0 Answers

How can I add the emission property to Unity's built-in Standard Surface Shader? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges