If Else Statement does both

Question

So I am trying to make a block that's basically a dice roll for a shortcut but half of the time it does both sides of the if statements.

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class RNG : MonoBehaviour
 {
     public GameObject edge;
     public int rngval;
 
     void OnTriggerEnter2D(Collider2D col)
     {
         rngval = Random.Range(0,2);
         if(col.tag == "Player")
         {
             if(rngval==0){
                 Destroy(gameObject);
                 Destroy(edge.gameObject);
             } else {
                 col.transform.position = CheckPoint.GetActiveCheckPointPosition();
                 Destroy(gameObject);
             }
         }
     }
 }

Answer 1

Answer by Bunny83 · Oct 01, 2020 at 09:29 AM

Are you sure that you only get a single collision? Maybe this script is attached to more than one object? Keep in mind that destroying the gameobject only has effect at the end of the current frame. An if-else statement can never execute both bodies. This is only possible when you run the code two times or more often.

Please learn how to debug such observations. Just place some Debug.Logs in your code to see how often it actually runs. It's probably a good idea to print out the rngval you rolled as well. Note that you can pass a gameobject reference as second parameter to Debug.Log. This gameobject is a "context" object. When you click on the log message in the console, Unity will highlight / ping that context object. This makes it easier to identify which object has actually created this message.

1 Show 1 · Share

saperoi · Oct 01, 2020 at 04:35 PM 0

Share

Yeah thanks for the reply but I eventually decided to remove the Box Collider entirely, because to get some of the things to work as I'd like them to, I use 2 colliders, one trigger and one not. Maybe it's bad practice, but when the non-trigger collider got removed and I removed the Destroy(gameObject); it actually started working properly.

If Else Statement does both

1 Reply

Unity Answers is in Read-Only mode

Follow this Question

Related Questions