• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Karks · Dec 09, 2020 at 11:02 PM · 2d gameraycasthit2dtop down shooter

My raycasting script stops on error in play mode and i can't find out why

Hi, im new to unity and im trying to implement a weapon into my 2d top down shooter, which hits enemies via raycast and with an explosion on hit, or mouse position if player missed an enemy, using this script

 public class Player_MagdoomShooting : MonoBehaviour
 {
     public Transform MagdoomCannonmuzzle;
 
     public Transform player;
 
     public LayerMask enemyLayer;
 
     public float blastRadius = 1f;
 
     private float ContactPointDistance;
 
     private Vector3 mousePos;
 
     void Update()
     {
         mousePos = Camera.main.ScreenToWorldPoint(Input.mousePosition);
         Vector2 direction = mousePos - MagdoomCannonmuzzle.position;
         ContactPointDistance = Vector2.Distance(MagdoomCannonmuzzle.position, mousePos);
         if (Input.GetButtonDown("Fire2"))
         {
             Debug.DrawRay(MagdoomCannonmuzzle.position, direction, Color.yellow, ContactPointDistance);
             RaycastHit2D hitInfo = Physics2D.Raycast(MagdoomCannonmuzzle.position, direction, ContactPointDistance);
             if (hitInfo.collider.gameObject.CompareTag("enemy"))
             {
                 Collider2D[] explosion = Physics2D.OverlapCircleAll(hitInfo.rigidbody.ClosestPoint(MagdoomCannonmuzzle.position), blastRadius, enemyLayer);
                 foreach(Collider2D enemy in explosion)
                 {
                     Debug.Log(enemy.name + " was hit by explosion");
                 }
                 Debug.Log(hitInfo.transform.name + " was hit by ray");
             }
             else if (hitInfo.collider.gameObject.CompareTag("enemyBullet"))
             {
                 Collider2D[] explosion = Physics2D.OverlapCircleAll(hitInfo.rigidbody.ClosestPoint(MagdoomCannonmuzzle.position), blastRadius, enemyLayer);
                 foreach (Collider2D enemy in explosion)
                 {
                     Debug.Log(enemy.name + " was hit by explosion");
                 }
                 Debug.Log(hitInfo.transform.name + " was hit by ray");
             }
             else
             {
                 Collider2D[] explosion = Physics2D.OverlapCircleAll(mousePos, blastRadius, enemyLayer);
                 foreach (Collider2D enemy in explosion)
                 {
                     Debug.Log(enemy.name + " was hit by explosion");
                 }
             }
         }
     }
 }

For a reason i can't understand it works fine only if it hits something. if ray doesn't hit anything game gets error paused but console writes no message. It has to be something in "If" part, because it works without it.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Karks · Dec 10, 2020 at 11:54 AM

Fixed it. It was NullExpeption type of poblem. Rewrote script to this

 void Update()
     {
         mousePos = Camera.main.ScreenToWorldPoint(Input.mousePosition);
         Vector2 direction = mousePos - MagdoomCannonmuzzle.position;
         ContactPointDistance = Vector2.Distance(MagdoomCannonmuzzle.position, mousePos);
         if (Input.GetButtonDown("Fire2"))
         {
             Debug.DrawRay(MagdoomCannonmuzzle.position, direction, Color.yellow, ContactPointDistance);
             RaycastHit2D hitInfo = Physics2D.Raycast(MagdoomCannonmuzzle.position, direction, ContactPointDistance);
             if (hitInfo)
             {
                 Debug.Log(hitInfo.transform.name + " was hit by ray");
                 if (hitInfo.collider.gameObject.CompareTag("enemy"))
                 {
                     Debug.Log(hitInfo.transform.name + " will suffer damage");
                     Collider2D[] explosion = Physics2D.OverlapCircleAll(hitInfo.rigidbody.ClosestPoint(MagdoomCannonmuzzle.position), blastRadius, enemyLayer);
                     foreach (Collider2D enemy in explosion)
                     {
                         Debug.Log(enemy.name + " was hit by explosion");
                     }
                 }
                 else if (hitInfo.collider.gameObject.CompareTag("enemyBullet"))
                 {
                     Debug.Log(hitInfo.transform.name + " will suffer damage");
                     Collider2D[] explosion = Physics2D.OverlapCircleAll(hitInfo.rigidbody.ClosestPoint(MagdoomCannonmuzzle.position), blastRadius, enemyLayer);
                     foreach (Collider2D enemy in explosion)
                     {
                         Debug.Log(enemy.name + " was hit by explosion");
                     }
                 }
             }
             else
             {
                 Collider2D[] explosion = Physics2D.OverlapCircleAll(mousePos, blastRadius, enemyLayer);
                 foreach (Collider2D enemy in explosion)
                 {
                     Debug.Log(enemy.name + " was hit by explosion");
                 }
             }
         }
     }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.



Follow this Question

Answers Answers and Comments

185 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

2D top down shooter border. 1 Answer

I need help with a top down 2d shooter 3 Answers

How do I invert mouse movement for a specific section of my game? 3 Answers

How to make shooting in top down 2d shooter game? Unity 2d 1 Answer

2D 360 Shooting Is not working (Top Down, Shooting in all directions) 1 Answer

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges