Connecting/syncing two arrays ?

Question

 public class Mine : MonoBehaviour
 {
     [SerializeField] int health = 35;
     [SerializeField] ItemObject[] yield;
     [SerializeField] int[] amount;
 
     public void Mining(int strength)
     {
         if (health-strength > 0)
         {
             health -= strength;
         }
         else
         {
             Destroy(gameObject);
         }
     }
 
     public void OnDestroy()
     {
         for (int i = 0; i < yield.Length; i++)
         {
             Pickup pickup = Instantiate(PrefabsRef.prefabs.Pickup, transform.position, Quaternion.identity).GetComponent<Pickup>();
             pickup.ThrowAway(yield[i], amount[i]);
         }
     }
 }

Simple issue really, I have one class that handles all my pickups, so whenever I want to drop multiple stacks of items I just instantiate it multiple times using for loop.
As you see above my current implementation is not perfect and prone to errors as the two arrays are not synced. I have to set up items and the amounts seperately and I would prefer to set amount per each item entry.
Is there an easy way of doing it better or connecting those two arrays at least in the inspector ?

Answer 1

Best Answer

Answer by unity_ek98vnTRplGj8Q · Jan 04, 2021 at 06:29 PM

Rather than trying to sync 2 arrays usually its better to compile all the data into 1 array. Something like this:

 private struct ItemStack
 {
     ItemObject item;
     int amount;
 }
 
 ItemStack[] itemYeild;
 
 public void OnDestroy(){
     for(int i=0; i<itemYeild.Length; i++){
         pickup.ThrowAway(itemYeild[i].item, itemYeild[i].amount);
     }
 }

Add comment · Show 3 · Share

Inryhk · Jan 04, 2021 at 06:58 PM 0

Share

Thanks for quick answer! I already tried creating a seperate system.serializable class that would hold this info together which kinda works.

 [System.Serializable]
 public class Stack
 {
     public ItemObject item;
     public int amount;
 }

But struct makes so much more sense. Thanks for the help.

Eno-Khaon Inryhk · Jan 04, 2021 at 08:28 PM 0

Share

Just a heads up about this:

Queue and Stack are common (albeit less commonly seen in C# than lower-level languages) Collection types used in program$$anonymous$$g.

While it might not interfere with your project, it's a safer bet to not replace a Stack in case you decide you want to use one later.

Inryhk Eno-Khaon · Jan 06, 2021 at 01:13 PM 0

Share

Oh? thanks. So it would be cleaner to change the name of the struct so that it doesn't interfere with the collection type. Will do.

Connecting/syncing two arrays ?

1 Reply

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions