• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by falcxn_ · Mar 10, 2021 at 10:59 PM · controllerracingvehicles

Vehicle controller not working well

I am working on a racing game and have an issue with the vehicle controller. When the car gets moving the brake becomes very unresponsive and the car will keep accelerating until it hits something or spins out. The steering continues to work perfectly when moving but the acceleration seems to lock for some reason.

The code:

 using System;
 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public enum Axel
 {
     Front,
     Rear
 }
 
 [Serializable] public struct Wheel
 {
     public Transform model;
     public WheelCollider collider;
     public Axel axel;
 }
 
 public class CarController : MonoBehaviour
 {
     private Rigidbody _rigidbody;
     
     [SerializeField] private Transform _centerOfMass;
     [SerializeField] private float motorTorque = 1500f, maxSteer = 20f, breakTorque = 2500f;
     [SerializeField] private List<Wheel> wheels;
     [SerializeField] private bool allWheelDrive = false;
     
     [SerializeField] private bool isBreaking;
 
     private float horizontalInput, verticalInput;
 
     void Start()
     {
         _rigidbody = GetComponent<Rigidbody>();
         _rigidbody.centerOfMass = _centerOfMass.localPosition;
     }
 
     void Update()
     {
         UpdateWheels();
     }
 
     void FixedUpdate()
     {
         GetInput();
         Move();
         Steer();
     }
     
     void GetInput()
     {
         horizontalInput = Input.GetAxis("Horizontal");
         verticalInput = Input.GetAxis("Vertical");
         isBreaking = Input.GetKey(KeyCode.Space);
     }
 
     void Move()
     {
         foreach (var wheel in wheels)
         {
             if (allWheelDrive)
             {
                 wheel.collider.motorTorque = verticalInput * motorTorque;
                 if (isBreaking)
                 {
                     ApplyBreaking(breakTorque);
                 }
                 else
                 {
                     ApplyBreaking(0f);
                 }
             }
             else
             {
                 if (wheel.axel == Axel.Rear)
                 {
                     wheel.collider.motorTorque = verticalInput * motorTorque;
                     if (isBreaking)
                     {
                         ApplyBreaking(breakTorque);
                     }
                     else
                     {
                         ApplyBreaking(0f);
                     }
                 }
             }
         }
     }
 
     void Steer()
     {
         foreach (var wheel in wheels)
         {
             if (wheel.axel == Axel.Front)
             {
                 var _steerAngle = horizontalInput * maxSteer;
                 wheel.collider.steerAngle = Mathf.Lerp(wheel.collider.steerAngle, _steerAngle, 0.5f);
             }
         }
     }
 
     void UpdateWheels()
     {
         foreach (var wheel in wheels)
         {
             Vector3 _pos;
             Quaternion _rot;
             
             wheel.collider.GetWorldPose(out _pos, out _rot);
             wheel.model.position = _pos;
             wheel.model.rotation = _rot;
         }
     }
 
     void ApplyBreaking(float breakTorque)
     {
         foreach (var wheel in wheels)
         {
             if (wheel.axel == Axel.Rear)
             {
                 wheel.collider.brakeTorque = breakTorque;
             }
         }
     }
 }

Comment

People who like this

0 Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image GeroNL · Mar 11, 2021 at 07:41 AM 0
Share

Are you already debug your input? it is already in a condition you want it?


is your input work, then try to call apply breaking in update, it is breaking?


If the both work, well, i did not see anything wrong about your codes.

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

120 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

On screen button forward for a car (Android) 1 Answer

MMD How to export model and animations to Unity as 3rd person controller? 2 Answers

How would I make a 3rd person Controller that only moves up, down, left, and right? 2 Answers

The name 'Joystick' does not denote a valid type ('not found') 2 Answers

Sci Fi Racing Controls and Physics? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges