why does using "continue;" still gives error?

Question

So i was drafting a cute lil level up system (just a draft)...and i decided to use the array approach to tackle this.....so i wrote this simple piece of code....whenever i run the CheckLevel() Method....unity says that the index doesn't exist at cs: 37(which it doesn't...but since im using...

 if(levels[index + 1] == null)
 {
   continue;
 }

why does this still happen? Also, i realise that using return here would be the same, and that using these would mean that the last level of my array would not be checked......but why is this happening? Im sorry if it's something stupid....sorry and thanks in advance!

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using System;
 
 [System.Serializable]
 public class Level
 {
   public string levelname;
   public int serial;
   public int requiredxp;
   public int extrajumps;
   public int health;
   public int attackstrength;
 }
 
 public class PlayerStats : MonoBehaviour
 {
   public int coins;
   public int shadowxp;
   public int attacklevel = 1;
   public int attackstrength;
   public int level;
   public Level[] levels;
 
   [Header("Frame Counter")]
   public int lcframecount;
   public int activelccount;
 
 
     public void CheckLevel()
     {
       foreach(Level leveldata in levels)
       {
         int index = Array.FindIndex(levels, levels => levels == leveldata);
         leveldata.serial = index + 1;
         if(levels[index + 1] == null)
         {
           continue;
         }
         else if(shadowxp >= leveldata.requiredxp && shadowxp < levels[index + 1].requiredxp)
         {
           if(level != leveldata.serial)
           {
             level = leveldata.serial;
             Debug.Log("your level is " + level + " so you are now a " + leveldata.levelname);
             this.gameObject.GetComponent<PlayerMovement>().extrajumps = leveldata.extrajumps;
             this.gameObject.GetComponent<PlayerCombat>().maxhealth = leveldata.health;
             attackstrength = leveldata.attackstrength;
           }
         }
       }
     }
 
     void DebugLevels()
     {
       foreach(Level leveldata in levels)
       {
         leveldata.serial = Array.FindIndex(levels, levels => levels == leveldata) + 1;
       }
     }
 
     void Start()
     {
       activelccount = lcframecount;
       CheckLevel();
     }
 
     void Update()
     {
       if(activelccount > 0)
       {
         activelccount--;
       }
       else if(activelccount <= 0)
       {
         CheckLevel();
         activelccount = lcframecount;
       }
     }
 }

Answer 1

Best Answer

Answer by Ruchir · Jul 07, 2021 at 11:46 AM

It does look like a simple IndexOutOfBounds exception to me.

When you are the last index you just can't check the array for "Index + 1", you should just check for "index < size -1" before if you want to access "index + 1" in an array.

Add comment · Show 4 · Share

rage_co · Jul 07, 2021 at 11:55 AM 0

Share

Thanks man! that worked quite well

rage_co · Jul 07, 2021 at 11:57 AM 0

Share

So c# doesn't allow to check null array elements with arrays and lists i guess?

Ruchir rage_co · Jul 07, 2021 at 12:19 PM 1

Share

You can check an element for null in an array. The problem here is that you can't check an array for indexes beyond its size.

for example,

 GameObject[] objects = new GameObject[3];
 
 objects[0].something = something; //Not valid since we didn't assign a value so it will give a nullRef error
 
 if(objects[0] == null) //Valid since it's inside size limit (0 < 3)
 {
     //Do something
 }
 
 if(objects[3] == null) //Not valid since index are till size -1 only so till "objects[2]"
 {
     //Do something
 }

rage_co Ruchir · Jul 07, 2021 at 01:26 PM 0

Share

hmmm, makes sense...thanks for the help

why does using "continue;" still gives error?

1 Reply

Welcome to Unity Answers

Follow this Question

Related Questions