Question by Angela0223 · Nov 29, 2021 at 11:54 AM · firing wont stop

My gun wont stop firing

My gun wont stop firing can someone help me thanks. using System.Collections; using System.Collections.Generic; using UnityEngine; using UnityEngine.UI;

public class AmmoDisplay : MonoBehaviour { public int ammo; public bool isFiring; public Text ammoDispay;

 // Start is called before the first frame update
 void Start()
 {
     
 }

 // Update is called once per frame
 void Update()
 {
     ammoDispay.text = ammo.ToString(); // Display On Your Current Ammo
     if(Input.GetMouseButtonDown(0) && !isFiring && ammo > 0)
     {
         isFiring = true;
         ammo--;
         isFiring = false;
     }
     if (Input.GetKeyDown(KeyCode.R))
     {
         ammo = 25;
     }
     if (ammo <= 0)
     {
         isFiring = false;
     }
 }

}

0 Show 15

MilitaryG · Nov 29, 2021 at 12:13 PM 0

Change isFiering to canFire

Also in mouse event change to canFire without " ! "

Like this

 if(Input.GetMouseButtonDown(0) && canFire && ammo > 0){
     ammo --;
 }

nothing else in mouse event

And when you press r make

 canFire = true;
 ammo = 25;

Than it should do it

Angela0223 MilitaryG · Nov 29, 2021 at 12:43 PM 0

If I remove ! it won't subtract my ammo it just stays at 25.

MilitaryG Angela0223 · Nov 29, 2021 at 12:47 PM 0

The !

Is checking the canFire if it's false

So if you remove !

It checks if canFire is true

Show more comments

Angela0223 MilitaryG · Nov 29, 2021 at 12:46 PM 0

And its still firing if its 0 I will give you another script maybe its from my bulletimpact I am probably not firing I just can see my bulletimpact

Angela0223 MilitaryG · Nov 29, 2021 at 12:46 PM 0

using Photon.Pun; using System.Collections; using System.Collections.Generic; using UnityEngine;

public class SingleShotGun : Gun { [SerializeField] Camera cam;

 PhotonView PV;

 void Awake()
 {
     PV = GetComponent<PhotonView>();
 }

 public override void Use()
 {
     Shoot();
 }

 void Shoot()
 {
     Ray ray = cam.ViewportPointToRay(new Vector3(0.5f, 0.5f));
     ray.origin = cam.transform.position;
     if(Physics.Raycast(ray, out RaycastHit hit))
     {
         hit.collider.gameObject.GetComponent<IDamageable>()?.TakeDamage(((GunInfo)itemInfo).damage);
         PV.RPC("RPC_Shoot", RpcTarget.All, hit.point, hit.normal);
     }
 }

 [PunRPC]
 void RPC_Shoot(Vector3 hitPosition, Vector3 hitNormal)
 {
     Collider[] colliders = Physics.OverlapSphere(hitPosition, 0.3f);
     if(colliders.Length != 0)
     {
         GameObject bulletImpactObj = Instantiate(bulletImpactPrefab, hitPosition + hitNormal * 0.001f, Quaternion.LookRotation(hitNormal, Vector3.up) * bulletImpactPrefab.transform.rotation);
         Destroy(bulletImpactObj, 10f);
         bulletImpactObj.transform.SetParent(colliders[0].transform);
     }
 }

}

MilitaryG Angela0223 · Nov 29, 2021 at 01:01 PM 0

Can't see AmmoDispley in here so i think it's not related. To this script.

I posted how code should look like

Tho you will empty your gun in about a second

Show more comments

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta by June 9. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.

Answers Answers and Comments

170 People are following this question.