Why doesn't this script work?

Question

So i was trying to make an animation play when the speed is 0 and when it isnt 0. Turns out that's not how it works, so it just made me not move at all with the idle animation. Please help me fix this script.

          void Update()
         {
         if(Input.GetKeyUp("a"))
         {
             speed = 25;
         }
         else
         {
             speed = 0;
         }

         if(Input.GetKeyUp("d"))

         {
             speed = 25;
         }
         else
         {
             speed = 0;
         }


        if(speed != 0f)
        {
           playerAnimator.SetBool("isRunning", true);
        }
        else
        {
           playerAnimator.SetBool("isRunning", false);
        }

Answer 1

Best Answer

Answer by tormentoarmagedoom · Jun 25, 2022 at 12:50 PM

Hello.

Did you know there are 3 Getkey funtions?

GetKey(): All frames while is pressed

Getkeydown(): The first frsme is pressed

Getkeyup(): The next frame after is released.

Goo find unity documentation about all 3.

Also, this code still needs the closing } for the update function.

Bye!

0 Show 8 · Share

Markasabrt · Jun 25, 2022 at 04:46 PM 0

Share

Thanks man!

Markasabrt · Jun 25, 2022 at 04:52 PM 0

Share

Sorry, but for some reason i can walk right and can't walk left. Any explanation? The animation also works!

         void Update()
         {
         if(Input.GetKey("a"))
         {
             speed = 25;
         }
         else
         {
             speed = 0;
         }

         if(Input.GetKey("d"))

         {
             speed = 25;
         }
         else
         {
             speed = 0;
         }


        if(speed != 0f)
        {
           playerAnimator.SetBool("isRunning", true);
        }
        else
        {
           playerAnimator.SetBool("isRunning", false);
        }

tormentoarmagedoom Markasabrt · Jun 25, 2022 at 06:23 PM 0

Share

Well, in your code is not consistent.

If you press a, lime 5 makes speed =25 but at same time line 19 makes speed 0

you need do diferent structure

 if....a.... 25
 else if....d....-25  (its -25, so movement to other side)
 else... 0

so only one of the 3 options will be executed

Why doesn't this script work?

1 Reply

Unity Answers is in Read-Only mode

Follow this Question

Related Questions