This question was closed Jan 20, 2012 at 01:26 AM by digitalConundrum for the following reason:

Question was wrong, simple mistake, no answers submitted before problem found...comments reflect this.

Question by digitalConundrum · Jan 20, 2012 at 12:33 AM · c#crash list broadcastmessage

Unity crashing with BroadcastMessage (possibly not thread safe?)

I have a random number of nodes which are connected via a structure I call the transfer manager. It allows items to be transferred from one node to another. As far as my testing has gone, everything seemed to work perfectly until I implemented BroadcastMessage to call a function on every transfer manager, followed by a call to every node.

very simply this starts the call:

 if(GUI.Button(new Rect(Screen.width-101,0, 100, 100), "End Turn"))
         {
             allParent.BroadcastMessage("ResolveTransfers");
         }

followed by this script running on all transferManagers simultaneously.

 void ResolveTransfers()
     {
         
         if (tempOne.fleetShips > 0 && tempTwo.fleetShips > 0 && tempOne != tempTwo)
         {
             List<Fleet> tempList=new List<Fleet>();
             tempList.Add(tempOne);
             tempList.Add(tempTwo);
             Fleet.Battle(tempList);
         }
 
         if (tempOne != null)
         {
             two.AddFleet(tempOne);
         }
 
         if (tempTwo != null)
         {
             two.AddFleet(tempTwo);
         }
 
 
         tracker++;
 
 
         if (tracker== count)
         {
             print(count);            
             GUIWindows.instance.allParent.BroadcastMessage("OnEndOfTurn");
             tracker = 0;
         }
     }

The part that concerns me is the last part, Its designed so that the message is sent only once: when the last running instance of the script (count is static and incremented in start, so it should be the number of instances) hits that point, but I'm starting to think that it might not be thread safe and is causing the crash? The next broadcastMessage is only calling an empty function at the moment, so its not the problem.

I'm really at a loss here and I've wasted 6 hours today trying to get this working. I would really appreciate any help with this.

0 Show 2

Tyler 10 · Jan 20, 2012 at 01:16 AM 1

Its tough to say what you are experiencing, but make sure that by broadcasting GUIWindows.instance.allParent.BroadcastMessage("OnEndOfTurn");

your code doesn't call: BroadcastMessage("ResolveTransfers"); again. This would throw unity into a infinite loop, you would get no error messages, it would just lock up, sit there for a few seconds and quit.

digitalConundrum · Jan 20, 2012 at 01:25 AM 0

I actually just found the problem, I overloaded the equality operator and then inside the operator checked if it was == null, causing infinite recursion. Thanks for the time though, closing question.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Unity crashing with BroadcastMessage (possibly not thread safe?)

0 Replies

Welcome to Unity Answers

Follow this Question

Related Questions